Skip to content

Only apply VeloxParquetWriterInjects and NativeWritePostRule for Spark 3.3 #11787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JkSelf merged 2 commits into from
Mar 19, 2026
+6 −2
Merged

Only apply VeloxParquetWriterInjects and NativeWritePostRule for Spark 3.3 #11787

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a7a240
Only apply VeloxParquetWriterInjects and NativeWritePostRule for Spar…
JkSelf Mar 18, 2026
6c1f425
Resolve comments
JkSelf Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxListenerApi.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import org.apache.gluten.memory.{MemoryUsageRecorder, SimpleMemoryUsageRecorder}
import org.apache.gluten.memory.listener.ReservationListener
import org.apache.gluten.memory.memtarget.MemoryTarget
import org.apache.gluten.monitor.VeloxMemoryProfiler
import org.apache.gluten.sql.shims.SparkShimLoader
import org.apache.gluten.udf.UdfJniWrapper
import org.apache.gluten.utils._

Expand Down Expand Up @@ -238,8 +239,11 @@ class VeloxListenerApi extends ListenerApi with Logging {

// Inject backend-specific implementations to override spark classes.
GlutenFormatFactory.register(new VeloxParquetWriterInjects)
GlutenFormatFactory.injectPostRuleFactory(
session => GlutenWriterColumnarRules.NativeWritePostRule(session))
// Only register NativeWritePostRule for Spark 3.3
if (SparkShimLoader.getSparkVersion.startsWith("3.3")) {
GlutenFormatFactory.injectPostRuleFactory(
session => GlutenWriterColumnarRules.NativeWritePostRule(session))
}
GlutenFormatFactory.register(new VeloxRowSplitter())
}

Expand Down
Loading