[FLINK] Replace LinkedList with ArrayDeque and pre-size HashSet in Flink module#11789
Draft
acvictor wants to merge 1 commit intoapache:mainfrom
Draft
[FLINK] Replace LinkedList with ArrayDeque and pre-size HashSet in Flink module#11789acvictor wants to merge 1 commit intoapache:mainfrom
acvictor wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR makes minor collection improvements in Flink by replacing
LinkedListwithArrayDequefor the internal row buffer - provides O(1) foraddat tail,remove(0)from head with better cache locality thanLinkedListwhich allocates a separate node object per element, and using pre-sizeHashSetinanalyzeJoinKeysto avoid rehashing when the key count exceeds the default capacity (16 initial capacity x 0.75 load factor = rehash after 12 elements).How was this patch tested?
Existing UTs
Was this patch authored or co-authored using generative AI tooling?
No