GUACAMOLE-2210: Add support for AAD authentication to RDP protocol.#633
GUACAMOLE-2210: Add support for AAD authentication to RDP protocol.#633aleitner wants to merge 2 commits intoapache:staging/1.6.1from
Conversation
|
Didn't realize we don't have curl. This would require adding curl as a dependency |
14d083e to
ff25596
Compare
necouchman
left a comment
There was a problem hiding this comment.
Looks like the build is failing with an error about the switch() statement and one of the enums.
ff25596 to
de377cf
Compare
Ahh whoops! I was testing with only freerdp3 as that's when AAD support was implemented. Just added a case to the switch for freerdp2 so that it errors if AAD is selected |
| /** | ||
| * User-Agent string sent with all HTTP requests to Microsoft login endpoints. | ||
| * A browser-like UA is required to avoid "unsupported browser" responses. | ||
| */ | ||
| #define GUAC_AAD_USER_AGENT \ | ||
| "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 " \ | ||
| "(KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36" |
There was a problem hiding this comment.
Are we going to need to continually update this value to avoid being re-flagged as unsupported due to the claimed version being old?
There was a problem hiding this comment.
Not sure if this is an insane idea ... but we could calculate the expected current Chrome release from the current date based on their published major release cadence ...
There was a problem hiding this comment.
Microsoft's endpoints don't appear to validate browser version freshness currently. On the other hand we could fetch the latest stable major version from Google's VersionHistory API:
https://versionhistory.googleapis.com/v1/chrome/platforms/linux/channels/stable/versions
There was a problem hiding this comment.
Made the changes to get the latest chrome version!
There was a problem hiding this comment.
Unfortunately, phoning Google from within guacd is going to be a privacy issue. I don't think we can go this route.
7989a72 to
37b1d5a
Compare
AadSecuritymode#include "config.h"to source files that were missing it, fixing struct member offset mismatches.Authentication Flow
When
security=aadis set on an RDP connection:GetAccessTokencallback with the required scope and Proof-of-Possession keyguac_argvif not already configuredGatewayAvdClientIDsetting and thecommontenant endpoint$ConfigJavaScript object is parsed for session tokens (sFT,sCtx,urlPost,canary,apiCanary)GetCredentialTypeAPI is called to update server-side session state and obtain a fresh flow tokenPaired with apache/guacamole-client#1168