GUACAMOLE-2213: New function, guac_terminal_unknown_osc, to ignore unrecognised OSC sequences#654
Merged
mike-jumper merged 2 commits intoapache:staging/1.6.1from Apr 6, 2026
Conversation
necouchman
reviewed
Mar 31, 2026
mike-jumper
requested changes
Apr 2, 2026
Contributor
|
I think it's probably worth pulling this into 1.6.1, if you want to rebase against Didn't notice on my initial read, but: Please also either rebase to combine commit 5cbf029 into the initial commit or fix the message to include the JIRA issue, cover the high-level nature of the change, etc. (same style and standard as any other commit). |
andywarduk
force-pushed
the
GUACAMOLE-2213
branch
2 times, most recently
from
05e9b72 to
274630e
Compare
…known OSC sequences
andywarduk
force-pushed
the
GUACAMOLE-2213
branch
from
274630e to
095dce0
Compare
Contributor
Author
|
I've rebased to staging/1.6.1 (after a couple of failed attempts, sorry) and squashed the commits in to one with a compliant commit message. |
Contributor
Author
|
Btw, pull request 613 seems to be an alternative fix for this. |
necouchman
reviewed
Apr 3, 2026
mike-jumper
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
guac_terminal_osc in src/terminal/terminal-handlers.c does not correctly ignore unrecognised OSC sequences. It will revert to guac_terminal_echo on the first unrecognised character received.
The patch sets the character handler to a new function, guac_terminal_unknown_osc which ignores all characters until ECMA-48 ST (String Terminator).