HADOOP-19758. Avoid tput in shell usage formatting when unavailable.#8387
Open
deepujain wants to merge 1 commit intoapache:trunkfrom
Open
HADOOP-19758. Avoid tput in shell usage formatting when unavailable.#8387deepujain wants to merge 1 commit intoapache:trunkfrom
deepujain wants to merge 1 commit intoapache:trunkfrom
Conversation
Contributor
Author
|
Fixed the usage formatter to skip |
Contributor
|
Cool nice job. When i mentioned it I never thought someone else wold fix! I just installed ncurses in my docker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid invoking
tputwhen it is not installed, so Hadoop shell usage formatting works on minimal distros without ncurses.Change
hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh: guard the terminal-width probe withcommand -v tputand fall back cleanly to the default width.hadoop-common-project/hadoop-common/src/test/scripts/hadoop_subcommands.bats: add a regression for the missing-tputpath.JIRA
Fixes HADOOP-19758