Re-running the failed test is not helping, so reverting#2511
Merged
Conversation
xyuanlu
approved these changes
May 27, 2023
Contributor
Author
xyuanlu
pushed a commit
to xyuanlu/helix
that referenced
this pull request
Jul 14, 2023
Re-running the failed test is not helping, so reverting the retry added.
xyuanlu
pushed a commit
to xyuanlu/helix
that referenced
this pull request
Jul 15, 2023
Re-running the failed test is not helping, so reverting the retry added.
xyuanlu
pushed a commit
to xyuanlu/helix
that referenced
this pull request
Jul 19, 2023
Re-running the failed test is not helping, so reverting the retry added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes Need to fix Helix-CI #2403
Description
A while back, in order to improve the CI pass rate, we introduced auto-retry attempt to 5.
Jiajun pointed out that it is not helping as part of the PR#2403.
So I am reverting the change.
Tests
(List the names of added unit/integration tests)
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
I tested this fix in a separate branch:
desaikomal#3
It is all tests have passed. So this should be good.
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)