Skip to content

Re-running the failed test is not helping, so reverting#2511

Merged
qqu0127 merged 1 commit into
apache:masterfrom
desaikomal:fix-2403
May 28, 2023
Merged

Re-running the failed test is not helping, so reverting#2511
qqu0127 merged 1 commit into
apache:masterfrom
desaikomal:fix-2403

Conversation

@desaikomal

Copy link
Copy Markdown
Contributor

Issues

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    A while back, in order to improve the CI pass rate, we introduced auto-retry attempt to 5.
    Jiajun pointed out that it is not helping as part of the PR#2403.
    So I am reverting the change.

Tests

  • The following tests are written for this issue:

(List the names of added unit/integration tests)

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
I tested this fix in a separate branch:
desaikomal#3

It is all tests have passed. So this should be good.

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@desaikomal

Copy link
Copy Markdown
Contributor Author

Thanks @xyuanlu for review. This change has been approved by @xyuanlu and ready to be merged.
Commit message: Re-running the failed test is not helping, so reverting the retry added.

@qqu0127 qqu0127 merged commit cc8a337 into apache:master May 28, 2023
xyuanlu pushed a commit to xyuanlu/helix that referenced this pull request Jul 14, 2023
Re-running the failed test is not helping, so reverting the retry added.
xyuanlu pushed a commit to xyuanlu/helix that referenced this pull request Jul 15, 2023
Re-running the failed test is not helping, so reverting the retry added.
xyuanlu pushed a commit to xyuanlu/helix that referenced this pull request Jul 19, 2023
Re-running the failed test is not helping, so reverting the retry added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need to fix Helix-CI

3 participants