HIVE-29262: Incorrect column ordering output in case of different ordering of mutual columns in query & window function in vectorized PTF#6512
Open
tanishq-chugh wants to merge 5 commits into
Conversation
asf-ci-hive
added
tests pending
tests unstable
and removed
tests pending
tests unstable
labels
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
tanishq-chugh
force-pushed
the
HIVE-29262
branch
from
62d8db8 to
ca4ac35
Compare
asf-ci-hive
added
tests pending
tests unstable
tests passed
and removed
tests unstable
tests pending
labels
tanishq-chugh
changed the title
tanishq-chugh
changed the title
difin
reviewed
Jun 17, 2026
| LOAD DATA LOCAL INPATH '../../data/files/web_sales_2k' OVERWRITE INTO TABLE web_sales_txt; | ||
| select ws_bill_customer_sk,ws_item_sk from web_sales_txt; | ||
|
|
||
| SET hive.vectorized.execution.enabled; |
Contributor
There was a problem hiding this comment.
Why is this line needed? hive.vectorized.execution.enabled is set to true on line 1.
Contributor
Author
difin
reviewed
Jun 17, 2026
| ws_sold_date_sk, | ||
| ws_sales_price, | ||
| LAG(ws_sales_price) OVER ( | ||
| PARTITION BY ws_item_sk,ws_bill_customer_sk |
Contributor
There was a problem hiding this comment.
Please add a space between ws_item_sk,ws_bill_customer_sk
difin
reviewed
Jun 17, 2026
Comment on lines
+97
to
+99
| SET hive.vectorized.execution.enabled=false; | ||
|
|
||
| SET hive.vectorized.execution.enabled; |
Contributor
There was a problem hiding this comment.
This line seems unnecessary: SET hive.vectorized.execution.enabled;
difin
reviewed
Jun 17, 2026
| ORDER BY ws_sold_date_sk | ||
| ) AS sales_price_diff | ||
| FROM | ||
| web_sales_txt; |
Contributor
There was a problem hiding this comment.
Can you add comments explaining what test case is being tested before this and other SELECT queries in this .q file?
Contributor
Author
There was a problem hiding this comment.
Yes, comments would be essential to explain this Qtest. Added comments to explain all the SELECT queries being run in the Qtest in commit: a5e3bfc
…ering of mutual columns in query & window function
tanishq-chugh
force-pushed
the
HIVE-29262
branch
from
ca4ac35 to
a5e3bfc
Compare
tanishq-chugh
changed the title
asf-ci-hive
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Reorder partition columns so they match the key input column sequence during Partitioned Table Function (PTF) execution
Why are the changes needed?
To ensure, the query column ordering is maintained in case of mutual columns in query and PTF having different ordering
Does this PR introduce any user-facing change?
Yes, the column ordering in the query now matches as the input column sequence provided by the user
How was this patch tested?
Manual Testing + added Qtest