Open
Conversation
jiacai2050
requested changes
Feb 6, 2025
| let metric_ids = samples | ||
| .iter() | ||
| .map(|s| MetricId(hash(s.name.as_slice()))) | ||
| .collect::<Vec<_>>(); |
Contributor
There was a problem hiding this comment.
We should avoid create new Vec in write path, it will hurt perf.
| }); | ||
|
|
||
| // 2.1 update cache metrics | ||
| futures::future::join_all( |
Contributor
There was a problem hiding this comment.
We should do this in MetricManager module.
| } | ||
| } | ||
|
|
||
| pub struct CacheManager { |
Contributor
There was a problem hiding this comment.
For index cache manager, it will only cache series, metrics will be managed be metrics manager.
In this way, our code is more modular.
| } | ||
|
|
||
| struct TagIndexCache { | ||
| cache: DashMap<SegmentDuration, ConcurrentTagKVMap>, |
Contributor
There was a problem hiding this comment.
Two thoughts here:
- We should prefer std map over dash map, those third party may introduce unexpected bugs.
- For current segment cache, we can use an independent field to represent, so we can save one hashmap lookup.
Other questions we need to consider:
- How will you evict segment?
| )) | ||
| } | ||
|
|
||
| async fn load_from_storage(&mut self) -> Result<()> { |
Contributor
There was a problem hiding this comment.
The cache module shouldn't known how the persistence layer is implemented, we can move this method to IndexManager.
| Ok(()) | ||
| } | ||
|
|
||
| fn schema() -> Arc<Schema> { |
Contributor
There was a problem hiding this comment.
Cache module has no schema, this field belong to IndexManager.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
#1623
Detailed Changes
TODO:
Test Plan
UT