Bug fix: Use 1 second timeout when closing out connections inside a connection pool lock#725
Merged
ok2c merged 1 commit intoSep 16, 2025
Conversation
…onnection pool lock
Member
Author
|
@arturobernalg By the way, if you have spare bandwidth and inclination, there is one potential improvement idea one could experiment with. Presently |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a report on the dev list recently about clients getting stuck trying to close out a TLS connection while holding a lock on the connection pool, effectively rendering those clients completely disabled. I thought it should not never happen and it turned out I was wrong. The issue was known and got fixed in
corebut the fix never got applied toclient.Basically this change-set makes sure the socket timeout is set to 1 second before connections get closed out inside the pool lock.
@arturobernalg Please double-check.