Skip to content

Fixed Micrometer and OpenTelemetry dependency declaration#763

Merged
ok2c merged 1 commit into
apache:5.6.xfrom
ok2c:corrected-micrometer-opentelemetrty-dependency-declaration
Dec 10, 2025
Merged

Fixed Micrometer and OpenTelemetry dependency declaration#763
ok2c merged 1 commit into
apache:5.6.xfrom
ok2c:corrected-micrometer-opentelemetrty-dependency-declaration

Conversation

@ok2c

@ok2c ok2c commented Dec 7, 2025

Copy link
Copy Markdown
Member

@arturobernalg httpclient5-observation module dependency declaration is a mess. I tried my best to correct it but because it know literally nothing about the module and its purpose I need your input.

  • What version of Open Telemetry do you intend to use? 1.49.0 or 1.52.0. You declarations were conflicting
  • Why was Open Telemetry SDK was marked as runtime? Is it the only backend that the module intents to support or users should be able to choose different backends?
  • Why micrometer-core and micrometer-observation were marked optional. They looks very non-optional due to direct imports in the code. What as your intent?

More importantly, do you think the module is ready for GA? Are its APIs ready? Maybe we should skip one minor version and delay a GA release of this module?

@ok2c ok2c requested a review from arturobernalg December 7, 2025 17:37
@ok2c ok2c changed the title Fixed Micrometer and OpenTelemetry depeendency declaration Fixed Micrometer and OpenTelemetry dependency declaration Dec 7, 2025

@arturobernalg arturobernalg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ok2c thanks for cleaning up the POM and for raising these points.

The conflicting OpenTelemetry versions and the SDK as a runtime dependency were just leftovers from some local experiments that I did not clean up properly – my mistake. The intention is to use a single OTEL version (I would suggest 1.52.0, but I am happy to align with whatever you prefer for 5.6) and to depend only on the OTEL API in the module itself, leaving SDK and exporters entirely to the application.

From my side the module is ready to be used and safe to ship as GA: it is purely observational, does not change client behaviour, and lives in an isolated optional module that nothing else depends on, so there is no risk for existing users. If we need to refine the API later, we can still do it via the usual deprecation path without impacting the core or classic/async client APIs.

@ok2c ok2c force-pushed the corrected-micrometer-opentelemetrty-dependency-declaration branch from 034ef42 to d5aa47d Compare December 9, 2025 15:33
@ok2c ok2c merged commit 1f4dea7 into apache:5.6.x Dec 10, 2025
8 checks passed
@ok2c ok2c deleted the corrected-micrometer-opentelemetrty-dependency-declaration branch December 14, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants