Limit the length of content codec list that can be processed automatically#770
Merged
Conversation
arturobernalg
approved these changes
Dec 15, 2025
| final ParserCursor cursor = new ParserCursor(0, contentEncoding.length()); | ||
| final HeaderElement[] codecs = BasicHeaderValueParser.INSTANCE.parseElements(contentEncoding, cursor); | ||
| if (maxCodecListLen > 0 && codecs.length > maxCodecListLen) { | ||
| throw new ProtocolException("Codec list exceeds maxumum of " + maxCodecListLen + " elements"); |
Member
There was a problem hiding this comment.
- “maxumum” → maximum
- Should we validate maxCodecListLen and reject negative values with an
IllegalArgumentException?
Member
Author
There was a problem hiding this comment.
“maxumum” → maximum
Corrected
Should we validate maxCodecListLen and reject negative values with an IllegalArgumentException?
This is an internal class. We control the input. If we ever make the class public, that would be a reasonable improvement
ok2c
force-pushed
the
limit_codec_list_len
branch
from
4d1b8ec to
7ab0fea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I chose the default limit on 5 elements for no particular reason. I doubt even two compression codecs in the compression chain would be reasonable, so I chose 5 as 'crazy' enough for the majority of sane scenarios.
@arturobernalg Please rewiew