Upgrade Apache RAT#779
Merged
Merged
Conversation
Contributor
Author
|
@ok2c @garydgregory Is ECLIPSE("The files and directories created by an Eclipse IDE based tool.",
Arrays.asList("**/.checkstyle", "**/.classpath", "**/.factorypath",
"**/.project", "**/.settings/**", "**/.externalToolBuilders/**", "**/bin/**"),
null, null),I ran |
During local development, I'm regularly annoyed by spurious RAT failures. While RAT does have some limitations -- for example, because it never shells out to `git`, it can't ignore untracked files -- newer versions do have improved support for `.gitignore` files, including the global gitignore file when present at `~/.config/git/ignore` (the default location). Additionally, the default exclusions have been improved, so we no longer need quite as much manual configuration. Specific changes: 1. Bumped `apache-rat-plugin` directly to 0.17. (In the version of the Apache parent POM we are using, there is no property we can override to do this.) 2. Removed exclusions that are obsolete or covered by our defaults. 3. Changed `apache-rat:check` to only run in `:httpclient5-parent`, instead of separately validating each subproject. 4. Changed `<exclude>` to `<inputExclude>` as the former is now deprecated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During local development, I'm regularly annoyed by spurious RAT failures. While RAT does have some limitations -- for example, because it never shells out to
git, it can't ignore untracked files -- newer versions do have improved support for.gitignorefiles, including the global gitignore file when present at~/.config/git/ignore(the default location). Additionally, the default exclusions have been improved, so we no longer need quite as much manual configuration.Specific changes:
apache-rat-plugindirectly to 0.17. (In the version of the Apache parent POM we are using, there is no property we can override to do this.)apache-rat:checkto only run in:httpclient5-parent, instead of separately validating each subproject.<exclude>to<inputExclude>as the former is now deprecated.