Skip to content

fix(hubble): fix loadfile limit #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lokidundun wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(hubble): fix loadfile limit #719

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57cf5f0
fix: fix loadfile limit
lokidundun Mar 21, 2026
d3a3a46
optimize: use jobEntity.getJobSize()
lokidundun Mar 22, 2026
2aee07b
optimize: remove the unuse code
lokidundun Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ...le/hubble-be/src/main/java/org/apache/hugegraph/controller/load/FileUploadController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,12 +277,9 @@ private void checkFileValid(int connId, int jobId, JobManager jobEntity,

long totalFileSizeLimit = this.config.get(
HubbleOptions.UPLOAD_TOTAL_FILE_SIZE_LIMIT);
List<FileMapping> fileMappings = this.service.listAll();
long currentTotalSize = fileMappings.stream()
.map(FileMapping::getTotalSize)
.reduce(0L, (Long::sum));
long currentTotalSize = jobEntity.getJobSize();
Ex.check(fileSize + currentTotalSize <= totalFileSizeLimit,
"load.upload.file.exceed-single-size",
"load.upload.file.exceed-total-size",
FileUtils.byteCountToDisplaySize(totalFileSizeLimit));
Comment on lines 278 to 283
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The total upload limit is now computed by summing total_size across all FileMapping records for the connection. Since completed mappings are persisted (and totalSize is set on completion), this quota becomes cumulative across jobs and won’t “reset” when a new job is created, which seems to be the core problem described in #496. Consider scoping the sum to the current job (conn_id + job_id), or using jobEntity.getJobSize() (which is already maintained on upload/delete) so the limit is enforced per job and naturally resets between jobs.

Copilot uses AI. Check for mistakes.
}

Expand Down
Loading