Skip to content

optimize: Optimize RocksDB batch query performance #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lokidundun wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −3
Open

optimize: Optimize RocksDB batch query performance #2982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...egraph-rocksdb/src/main/java/org/apache/hugegraph/backend/store/rocksdb/RocksDBTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
import java.util.HashSet;
import java.util.Iterator;
import java.util.List;
import java.util.Set;
Expand Down Expand Up @@ -180,7 +181,7 @@ protected BackendColumnIterator queryBy(RocksDBSessions.Session session, Query q
// Query by id
if (query.conditionsSize() == 0) {
assert query.idsSize() > 0;
return this.queryByIds(session, query.ids());
return this.getByIds(session, new HashSet<>(query.ids()));
}

// Query by condition (or condition + id)
Expand Down
4 changes: 2 additions & 2 deletions ...graph-rocksdb/src/main/java/org/apache/hugegraph/backend/store/rocksdb/RocksDBTables.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import java.nio.ByteBuffer;
import java.nio.ByteOrder;
import java.util.Collection;
import java.util.HashSet;
import java.util.List;

import org.apache.hugegraph.backend.id.Id;
Expand Down Expand Up @@ -182,8 +183,7 @@ protected BackendColumnIterator queryById(RocksDBSessions.Session session, Id id
@Override
protected BackendColumnIterator queryByIds(RocksDBSessions.Session session,
Collection<Id> ids) {
// TODO: use getByIds() after batch version multi-get is ready
return super.queryByIds(session, ids);
return this.getByIds(session, new HashSet<>(ids));
}
}

Expand Down
Loading