-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Build: Upgrade to Gradle 9.3.1 #15278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
1adb1f8
11af97b
dc62f84
9044d6c
4e08c75
c00b0d9
eed4282
c9fa498
0c7d376
b459e7d
6e08097
af66985
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,7 +36,6 @@ subprojects { | |
|
|
||
| // Thus we concede to applying all of the Baseline plugins individually on all the projects we are | ||
| // ready to enforce linting on. | ||
| apply plugin: 'org.inferred.processors' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what's the alternative to that plugin and the other one that's being removed? For reviewers it would be good to know why those are being removed
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. inferred plugin doesn't support Gradle 9. As all palantir gradle plugins, no change in the last 4 years.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The alternative is to use the native |
||
| if (!project.hasProperty('quick')) { | ||
| apply plugin: 'com.palantir.baseline-checkstyle' | ||
| apply plugin: 'com.palantir.baseline-error-prone' | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| // This file is intentionally minimal - BOM configuration is in root build.gradle |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -33,13 +33,13 @@ subprojects { | |||||
| task sourceJar(type: Jar, dependsOn: classes) { | ||||||
| archiveClassifier.set('sources') | ||||||
| from sourceSets.main.allSource | ||||||
| group 'build' | ||||||
| group = 'build' | ||||||
| } | ||||||
|
|
||||||
| task javadocJar(type: Jar, dependsOn: javadoc) { | ||||||
| archiveClassifier.set('javadoc') | ||||||
| from javadoc.destinationDir | ||||||
|
||||||
| from javadoc.destinationDir | |
| from javadoc.destinationDirectory.get().asFile |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -176,14 +176,16 @@ project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") { | |
| // all of those dependencies are required because the integration test extends FlinkTestBase | ||
| integrationCompileOnly project(':iceberg-api') | ||
| integrationImplementation libs.assertj.core | ||
| integrationImplementation libs.junit.jupiter | ||
| integrationImplementation libs.junit.platform.launcher | ||
| integrationImplementation project(path: ":iceberg-flink:iceberg-flink-${flinkMajorVersion}", configuration: "testArtifacts") | ||
| integrationImplementation project(path: ':iceberg-api', configuration: 'testArtifacts') | ||
| integrationImplementation project(path: ':iceberg-hive-metastore', configuration: 'testArtifacts') | ||
| integrationImplementation(libs.flink120.test.utils) { | ||
| exclude group: "org.apache.curator", module: 'curator-test' | ||
| exclude group: 'junit' | ||
| } | ||
|
|
||
| integrationImplementation libs.flink120.connector.base | ||
| integrationImplementation libs.flink120.table.api.java.bridge | ||
| integrationImplementation "org.apache.flink:flink-table-planner_${scalaVersion}:${libs.versions.flink120.get()}" | ||
|
|
||
|
|
@@ -226,7 +228,7 @@ project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") { | |
| shadowJar { | ||
| configurations = [project.configurations.runtimeClasspath] | ||
|
|
||
| zip64 true | ||
| zip64 = true | ||
|
|
||
| // include the LICENSE and NOTICE files for the shaded Jar | ||
| from(projectDir) { | ||
|
|
@@ -255,6 +257,9 @@ project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") { | |
| task integrationTest(type: Test) { | ||
| description = "Test Flink Runtime Jar against Flink ${flinkMajorVersion}" | ||
| group = "verification" | ||
| useJUnitPlatform { | ||
| excludeEngines "junit-vintage" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you please add some details about the issue that requires this change for better understanding? |
||
| } | ||
| jvmArgs += project.property('extraJvmArgs') | ||
| testClassesDirs = sourceSets.integration.output.classesDirs | ||
| classpath = sourceSets.integration.runtimeClasspath + files(shadowJar.archiveFile.get().asFile.path) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -76,7 +76,7 @@ project(':iceberg-mr') { | |
|
|
||
| test { | ||
| // testJoinTables / testScanTable | ||
| maxHeapSize '2500m' | ||
| maxHeapSize = '2500m' | ||
| } | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR removes application of
org.inferred.processorsandcom.palantir.baseline-exact-dependencies. Since that changes build enforcement/behavior (annotation processor handling and dependency verification), add a short comment here explaining why they were removed for the Gradle 9.3.1 upgrade (e.g., incompatibility/removal), and whether there is a replacement mechanism or intentional relaxation.