Skip to content

feat(partitions): implement partition background tasks#3564

Open
numinnex wants to merge 5 commits into
masterfrom
partition_background_workers
Open

feat(partitions): implement partition background tasks#3564
numinnex wants to merge 5 commits into
masterfrom
partition_background_workers

Conversation

@numinnex

Copy link
Copy Markdown
Contributor

This PR adds support for background tasks for partitions (segment cleaners). Additionally it adds support for DeleteSegment and PurgeTopic.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Jun 25, 2026
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 34.40308% with 511 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.80%. Comparing base (307fdb1) to head (80fb685).

Files with missing lines Patch % Lines
core/partitions/src/iggy_partition.rs 36.76% 215 Missing ⚠️
core/metadata/src/stm/stream.rs 52.41% 64 Missing and 5 partials ⚠️
core/server-ng/src/dispatch.rs 0.00% 67 Missing ⚠️
core/metadata/src/impls/metadata.rs 0.00% 41 Missing and 1 partial ⚠️
core/shard/src/router.rs 0.00% 34 Missing ⚠️
core/shard/src/lib.rs 0.00% 32 Missing ⚠️
core/server-ng/src/segment_cleaner.rs 0.00% 29 Missing ⚠️
core/server-ng/src/bootstrap.rs 0.00% 16 Missing ⚠️
core/server-ng/src/partition_reconciler.rs 80.00% 2 Missing and 4 partials ⚠️
core/consensus/src/observability.rs 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (34.40%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3564      +/-   ##
============================================
- Coverage     74.07%   73.80%   -0.27%     
  Complexity      937      937              
============================================
  Files          1249     1250       +1     
  Lines        128248   129018     +770     
  Branches     104116   104932     +816     
============================================
+ Hits          94994    95219     +225     
- Misses        30219    30705     +486     
- Partials       3035     3094      +59     
Components Coverage Δ
Rust Core 74.41% <34.40%> (-0.30%) ⬇️
Java SDK 62.44% <ø> (ø)
C# SDK 71.40% <ø> (-0.66%) ⬇️
Python SDK 88.88% <ø> (ø)
PHP SDK 84.29% <ø> (ø)
Node SDK 91.35% <ø> (ø)
Go SDK 40.14% <ø> (ø)
Files with missing lines Coverage Δ
core/binary_protocol/src/consensus/operation.rs 96.55% <100.00%> (+0.12%) ⬆️
core/binary_protocol/src/dispatch.rs 91.63% <ø> (ø)
core/metadata/src/stm/snapshot.rs 86.01% <100.00%> (+0.11%) ⬆️
core/partitions/src/segment.rs 93.54% <100.00%> (+38.37%) ⬆️
core/consensus/src/observability.rs 41.00% <0.00%> (-0.10%) ⬇️
core/server-ng/src/partition_reconciler.rs 86.73% <80.00%> (-0.21%) ⬇️
core/server-ng/src/bootstrap.rs 7.23% <0.00%> (-0.08%) ⬇️
core/server-ng/src/segment_cleaner.rs 0.00% <0.00%> (ø)
core/shard/src/lib.rs 71.55% <0.00%> (-2.42%) ⬇️
core/shard/src/router.rs 0.00% <0.00%> (ø)
... and 4 more

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread core/partitions/src/iggy_partition.rs
Comment thread core/partitions/src/iggy_partition.rs Outdated
Comment thread core/metadata/src/stm/stream.rs
@github-actions github-actions Bot added S-waiting-on-author PR is waiting on author response and removed S-waiting-on-review PR is waiting on a reviewer labels Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author PR is waiting on author response

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants