feat(bdd): unify rust image versions to slim-trixie#3569
Open
slbotbm wants to merge 5 commits into
Open
Conversation
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
slbotbm
changed the title
Contributor
|
do you think that it woudl be worth to add some machinery that would sync / check if its synced? maybe either reuse |
mmodzelewski
requested changes
Jun 26, 2026
|
|
||
| ARG RUST_VERSION=1.96 | ||
| FROM rust:${RUST_VERSION} | ||
| FROM rust:${RUST_VERSION}-slim-trixie |
Member
There was a problem hiding this comment.
actually, can we just drop this? it's directly followed by the gradle image, so there's no use of rust at all
github-actions
Bot
added
S-waiting-on-author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3569 +/- ##
=============================================
- Coverage 74.02% 48.25% -25.77%
Complexity 937 937
=============================================
Files 1247 1246 -1
Lines 127567 111705 -15862
Branches 103436 87618 -15818
=============================================
- Hits 94427 53907 -40520
- Misses 30104 54997 +24893
+ Partials 3036 2801 -235
🚀 New features to boost your workflow:
|
Contributor
Author
|
/ready |
github-actions
Bot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes rust-based images to slim-trixie version.
As an aside, there are a variety of versions (bookworm, bookworm-slim, trixie, trixie-slim, alpine) being used throughout the repo. Maybe it would be better to choose one version and utilize that everywhere?