Retry JS verification with approved version's lock files on mismatch#674
Open
Retry JS verification with approved version's lock files on mismatch#674
Conversation
When the initial JS build verification fails and a previously approved
version exists, retry the Docker build using the approved commit's
package.json and lock files. This handles the common case where a
version bump updates devDependencies (e.g. rollup, ncc) but the
committed dist/ was built with the old toolchain.
If the retry matches, the result is reported as a warning ("matches
with approved lock files, devDeps changed") rather than a hard failure,
with guidance to review the devDependency changes before approving.
Generated-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
This one addresees #669 -> I am also opening PR to address it in SonarSource as apparently they build the .javascript with version of dev tooling from the previous version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the initial JS build verification fails and a previously approved version exists, retry the Docker build using the approved commit's package.json and lock files. This handles the common case where a version bump updates devDependencies (e.g. rollup, ncc) but the committed dist/ was built with the old toolchain.
If the retry matches, the result is reported as a warning ("matches with approved lock files, devDeps changed") rather than a hard failure, with guidance to review the devDependency changes before approving.
Generated-by: Claude Opus 4.6 (1M context) noreply@anthropic.com