-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add PERCENTILE aggregation function and related validation #16545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FearfulTomcat27
wants to merge
1
commit into
apache:master
Choose a base branch
from
FearfulTomcat27:feat/percentile
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
159 changes: 159 additions & 0 deletions
159
...java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/Percentile.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,159 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.iotdb.db.queryengine.execution.operator.source.relational; | ||
|
|
||
| import org.apache.iotdb.db.exception.sql.SemanticException; | ||
|
|
||
| import org.apache.tsfile.utils.RamUsageEstimator; | ||
| import org.apache.tsfile.utils.ReadWriteIOUtils; | ||
|
|
||
| import java.nio.ByteBuffer; | ||
| import java.util.Arrays; | ||
|
|
||
| public class Percentile { | ||
| private double[] values; | ||
| private int size; | ||
| private int capacity; | ||
| private boolean sorted; | ||
|
|
||
| private static final int INITIAL_CAPACITY = 32; | ||
| private static final double GROWTH_FACTOR = 1.5; | ||
|
|
||
| public Percentile() { | ||
| this.capacity = INITIAL_CAPACITY; | ||
| this.values = new double[capacity]; | ||
| this.size = 0; | ||
| this.sorted = true; | ||
| } | ||
|
|
||
| public void addValue(double value) { | ||
| ensureCapacity(); | ||
| values[size++] = value; | ||
| sorted = false; | ||
| } | ||
|
|
||
| public void addValues(double... vals) { | ||
| if (vals == null || vals.length == 0) return; | ||
|
|
||
| int newSize = size + vals.length; | ||
| if (newSize > capacity) { | ||
| grow(newSize); | ||
| } | ||
|
|
||
| System.arraycopy(vals, 0, values, size, vals.length); | ||
| size = newSize; | ||
| sorted = false; | ||
| } | ||
|
|
||
| public void merge(Percentile other) { | ||
| if (other == null || other.size == 0) { | ||
| return; | ||
| } | ||
|
|
||
| int newSize = size + other.size; | ||
| if (newSize > capacity) { | ||
| grow(newSize); | ||
| } | ||
|
|
||
| System.arraycopy(other.values, 0, values, size, other.size); | ||
| size = newSize; | ||
| sorted = false; | ||
| } | ||
|
|
||
| public double getPercentile(double percentile) { | ||
| if (size == 0) { | ||
| return Double.NaN; | ||
| } | ||
| if (percentile < 0.0 || percentile > 1.0) { | ||
| throw new SemanticException("percentage should be in [0,1], got " + percentile); | ||
| } | ||
|
|
||
| ensureSorted(); | ||
|
|
||
| if (size == 1) { | ||
| return values[0]; | ||
| } | ||
|
|
||
| double realIndex = percentile * (size - 1); | ||
| int index = (int) realIndex; | ||
| double fraction = realIndex - index; | ||
|
|
||
| if (index >= size - 1) { | ||
| return values[size - 1]; | ||
| } | ||
|
|
||
| return values[index] + fraction * (values[index + 1] - values[index]); | ||
| } | ||
|
|
||
| public int getSize() { | ||
| return size; | ||
| } | ||
|
|
||
| public void clear() { | ||
| size = 0; | ||
| sorted = true; | ||
| } | ||
|
|
||
| private void ensureCapacity() { | ||
| if (size >= capacity) { | ||
| grow(size + 1); | ||
| } | ||
| } | ||
|
|
||
| private void grow(int minCapacity) { | ||
| int newCapacity = Math.max((int) (capacity * GROWTH_FACTOR), minCapacity); | ||
| double[] newValues = new double[newCapacity]; | ||
| System.arraycopy(values, 0, newValues, 0, size); | ||
| values = newValues; | ||
| capacity = newCapacity; | ||
| } | ||
|
|
||
| private void ensureSorted() { | ||
| if (!sorted && size > 1) { | ||
| Arrays.sort(values, 0, size); | ||
| sorted = true; | ||
| } | ||
| } | ||
|
|
||
| public void serialize(ByteBuffer buffer) { | ||
| ReadWriteIOUtils.write(size, buffer); | ||
| for (int i = 0; i < size; i++) { | ||
| ReadWriteIOUtils.write(values[i], buffer); | ||
| } | ||
| } | ||
|
|
||
| public static Percentile deserialize(ByteBuffer buffer) { | ||
| int size = ReadWriteIOUtils.readInt(buffer); | ||
| Percentile percentile = new Percentile(); | ||
| if (size > percentile.capacity) { | ||
| percentile.capacity = size; | ||
| percentile.values = new double[size]; | ||
| } | ||
| percentile.size = size; | ||
| for (int i = 0; i < size; i++) { | ||
| percentile.values[i] = ReadWriteIOUtils.readDouble(buffer); | ||
| } | ||
| return percentile; | ||
| } | ||
|
|
||
| public int getSerializedSize() { | ||
| return Integer.BYTES + (size * Double.BYTES); | ||
| } | ||
|
|
||
| public long getEstimatedSize() { | ||
| return RamUsageEstimator.shallowSizeOfInstance(Percentile.class) | ||
| + (long) capacity * Double.BYTES; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Percentile.deserialize() does not restore the 'sorted' state. Since serialize() writes values in their current internal order (which may be unsorted), leaving the deserialized instance with sorted=true can lead to incorrect getPercentile() results if the deserialized object is queried directly. Set sorted=false on deserialization (or serialize in sorted order) to preserve correctness.