Add FROM-first query syntax support#17410
Merged
JackieTien97 merged 3 commits intoapache:masterfrom Apr 8, 2026
Merged
Conversation
Contributor
Author
|
Hi @JackieTien97 , could you please review this PR when you have time? I’ve also sent a request to the dev mailing list, but it may have been filtered into the Promotions tab. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an additional, DuckDB-style FROM-first query form to IoTDB’s relational SQL dialect, enabling FROM <table> [SELECT ...] ... (with omitted SELECT implying SELECT *) while preserving existing SELECT-first syntax.
Changes:
- Extend the ANTLR grammar to parse
FROM-first query specifications as aqueryPrimary. - Add AST builder support to translate
FROM-first parse trees into the existingQuerySpecificationAST (including implicitSELECT *). - Add analyzer-level unit tests and a new integration test suite covering basic queries, implicit select, joins, and aggregation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| iotdb-core/relational-grammar/src/main/antlr4/org/apache/iotdb/db/relational/grammar/sql/RelationalSql.g4 | Adds fromFirstQuerySpecification and wires it into queryPrimary so queries can start with FROM. |
| iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/parser/AstBuilder.java | Builds a QuerySpecification from the new grammar rule, including implicit SELECT * behavior. |
| iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/AnalyzerTest.java | Adds unit tests to ensure FROM-first queries analyze/plan equivalently to SELECT-first equivalents. |
| integration-test/src/test/java/org/apache/iotdb/relational/it/query/recent/IoTDBFromFirstQueryIT.java | Adds integration coverage for end-to-end execution of FROM-first queries across common patterns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JackieTien97
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements support for the feature proposed in #17336 by introducing FROM-first query syntax.
Usage Examples
-- Current syntax
SELECT temperature, humidity FROM sensors WHERE time >= 10;
-- FROM-first syntax
FROM sensors SELECT temperature, humidity WHERE time >= 10;
-- Quick exploration (omitting SELECT implies SELECT *)
FROM sensors LIMIT 10;
Implementation Approach
Grammar Update
Add
fromFirstQuerySpecificationrule toRelationalSql.g4.AST Builder
Add
visitFromFirstQuerySpecification()inAstBuilder.java, reusing the existingvisitQuerySpecification()logic, with handling for the omitted SELECT clause (interpreted asSELECT *).Testing
Add unit and integration tests to cover the new syntax scenarios.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR