Skip to content

Fix flaky WALNodeTest WAL roll assertion#18226

Merged
jt2594838 merged 1 commit into
masterfrom
fix_wal_node_test_stability
Jul 16, 2026
Merged

Fix flaky WALNodeTest WAL roll assertion#18226
jt2594838 merged 1 commit into
masterfrom
fix_wal_node_test_stability

Conversation

@jt2594838

Copy link
Copy Markdown
Contributor

Wait for all synchronous WAL flush listeners before asserting rolled WAL file names. This prevents the test from observing the buffer as idle before the sync task completes WAL rolling. Validation: targeted test passed, plus 10 consecutive repeated runs passed.

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.78%. Comparing base (823c47e) to head (d0f1778).

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #18226      +/-   ##
============================================
- Coverage     42.79%   42.78%   -0.01%     
  Complexity      343      343              
============================================
  Files          5356     5356              
  Lines        380294   380294              
  Branches      49332    49332              
============================================
- Hits         162730   162707      -23     
- Misses       217564   217587      +23     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jt2594838
jt2594838 merged commit 2f7505f into master Jul 16, 2026
40 of 42 checks passed
@jt2594838
jt2594838 deleted the fix_wal_node_test_stability branch July 16, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant