Subscription: Fix DATE serialization for consensus dataset#18227
Open
Caideyipi wants to merge 2 commits into
Open
Subscription: Fix DATE serialization for consensus dataset#18227Caideyipi wants to merge 2 commits into
Caideyipi wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
For table-model topics with
format=datasetandmode=consensus, DATE columns in WAL insert nodes are represented asint[].ConsensusLogToTabletConverterreused those arrays in a TsFileTablet, whose DATE serialization requiresLocalDate[]. The resulting array type mismatch prevented subscription events from being generated, so pull consumers repeatedly received no messages.Reproduction: https://gitlab-eco.timecho.com/test/pipe-client/-/commit/1dcc9ccbbb2e6ee1ab8e8c95231dd05e314d08f4
Fix
int[]representation to the TabletLocalDate[]representation.LocalDatevalues.Tests
2026-01-31DATE value.ConsensusLogToTabletConverterTest: 13 tests passed.iotdb-core/datanodeand required upstream modules passed.This PR has:
Key changed/added classes (or packages if there are too many classes) in this PR
ConsensusLogToTabletConverterConsensusLogToTabletConverterTest