Skip to content

[Subscription] Reject unsupported consensus topic attributes#18257

Merged
jt2594838 merged 1 commit into
masterfrom
fix/consensus-topic-config-validation
Jul 21, 2026
Merged

[Subscription] Reject unsupported consensus topic attributes#18257
jt2594838 merged 1 commit into
masterfrom
fix/consensus-topic-config-validation

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

  • validate consensus topic attributes against the configurations consumed by the consensus runtime
  • report all unsupported attributes in deterministic order while preserving live and snapshot topic behavior
  • add localized error messages and ConfigNode validation tests

Tests

  • mvn spotless:apply -pl iotdb-core/confignode
  • SubscriptionInfoTopicValidationTest: 23 tests passed via targeted JUnit execution
  • changed ConfigNode sources compiled with both English and Chinese locale message classes

The standard module/reactor Maven runs are currently blocked by unrelated generated Thrift cache issues (fenceThresholdMs methods missing and stale javax.annotation.Generated output).

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.79%. Comparing base (1b44799) to head (83c81b9).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #18257      +/-   ##
============================================
+ Coverage     42.66%   42.79%   +0.12%     
  Complexity      343      343              
============================================
  Files          5356     5356              
  Lines        380375   380423      +48     
  Branches      49352    49361       +9     
============================================
+ Hits         162290   162805     +515     
+ Misses       218085   217618     -467     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jt2594838
jt2594838 merged commit 0f2ee2b into master Jul 21, 2026
43 of 44 checks passed
@jt2594838
jt2594838 deleted the fix/consensus-topic-config-validation branch July 21, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants