enable build with Maven 4

[hboutemy]

[INFO] -------------------------------------------------
[INFO] Build Summary:
[INFO]   Passed: 139, Failed: 11, Errors: 0, Skipped: 0
[INFO] -------------------------------------------------
Error:  The following builds failed:
Error:  *  projects/container-descriptors/custom-handler-withMixedEntries/pom.xml
Error:  *  projects/file-sets/multimodule-win-lineEndings/pom.xml
Error:  *  projects/dependency-sets/massembly-969/pom.xml
Error:  *  projects/container-descriptors/custom-containerDescriptorHandler/pom.xml
Error:  *  projects/mojo-configuration/massembly-291/pom.xml
Error:  *  projects/mojo-configuration/massembly-301/pom.xml
Error:  *  projects/file-sets/filtered-module-sources/pom.xml
Error:  *  projects/container-descriptors/custom-handler-withFileEntries/pom.xml
Error:  *  projects/dependency-sets/massembly-1008/pom.xml
Error:  *  projects/file-sets/filtered-multimodule/pom.xml
Error:  *  projects/bugs/massembly-891/pom.xml
[INFO] -------------------------------------------------

[hboutemy]

last IT failure fixed by #1320 , as it was also failing with Maven 3.10.0-SNAPSHOT

remaining ITs failures are specific to Maven 4

[hboutemy]

running now with Maven 4.0.0-SNAPSHOT gives me

[INFO] -------------------------------------------------
[INFO] Build Summary:
[INFO]   Passed: 146, Failed: 4, Errors: 0, Skipped: 0
[INFO] -------------------------------------------------
[ERROR] The following builds failed:
[ERROR] *  projects/dependency-sets/massembly-1008/pom.xml
[ERROR] *  projects/mojo-configuration/massembly-291/pom.xml
[ERROR] *  projects/mojo-configuration/massembly-301/pom.xml
[ERROR] *  projects/dependency-sets/massembly-969/pom.xml
[INFO] -------------------------------------------------

[Bukama]

An old issue about same topic (failing ITs with Maven 4): #1257

[hboutemy]

[ERROR] *  projects/mojo-configuration/massembly-291/pom.xml
[ERROR] *  projects/mojo-configuration/massembly-301/pom.xml

are caused by the same interpolation issue from test.properties as what was fixed in apache/maven-deploy-plugin@dd96008

[Bukama]

projects\dependency-sets\massembly-969

fails with invalid model

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:3.8.1-SNAPSHOT:single (assembly) on project massembly-969: Execution assembly of goal org.apache.maven.plugins:maven-assembly-plugin:3.8.1-SNAPSHOT:single failed: Duplicate key linux-x86_64 (attempted merging values org.apache.maven.api.model.Activation@4ea48b2e and org.apache.maven.api.model.Activation@72c704f1) -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:3.8.1-SNAPSHOT:single (assembly) on project massembly-969: Execution assembly of goal org.apache.maven.plugins:maven-assembly-plugin:3.8.1-SNAPSHOT:single failed: Duplicate key linux-x86_64 (attempted merging values org.apache.maven.api.model.Activation@4ea48b2e and org.apache.maven.api.model.Activation@72c704f1)

Guess this comes from all the FX dependencies for all the different OS and they all bring in their profile activation definition. Not yet sure how to fix this, except different ITs with only one dependency per OS. Will think about dinner first 🍽️

[Bukama]

projects\dependency-sets\massembly-969 fixed by updating dependency used in test (tested on Maven 3.9.16 and Maven 4.0.0-SNAPSHOT)

[Bukama]

[ERROR] *  projects/mojo-configuration/massembly-291/pom.xml
[ERROR] *  projects/mojo-configuration/massembly-301/pom.xml

are caused by the same interpolation issue from test.properties as what was fixed in apache/maven-deploy-plugin@dd96008

applied

[hboutemy]

please don't add repo that was not existent before: this will remove unwanted impact

[hboutemy]

I don't get how we can have so many fixes, and latest build on GHA says with Maven 4.0.0-RC5:

[INFO] -------------------------------------------------
[INFO] Build Summary:
[INFO]   Passed: 144, Failed: 6, Errors: 0, Skipped: 0
[INFO] -------------------------------------------------
Error:  The following builds failed:
Error:  *  projects/container-descriptors/custom-handler-withMixedEntries/pom.xml
Error:  *  projects/file-sets/multimodule-win-lineEndings/pom.xml
Error:  *  projects/container-descriptors/custom-containerDescriptorHandler/pom.xml
Error:  *  projects/file-sets/filtered-module-sources/pom.xml
Error:  *  projects/container-descriptors/custom-handler-withFileEntries/pom.xml
Error:  *  projects/file-sets/filtered-multimodule/pom.xml
[INFO] -------------------------------------------------

what is happening?
were the ITs rebased on master, to benefit from other fixes done in master?

[hboutemy]

just tested on my laptop: got it

works with Maven 4.0.0-SNAPSHOT, failures are specific to 4.0.0-RC5

great news: RC6 has fixed issues from RC5

@Bukama it seems you'll have to decouple the ITs improvements from the current PR, as enabling Maven 4 here will require rc6

[Bukama]

Reverted all my commits, so this branch is back to only enable Maven 4 build.