Fix IllegalStateException when cache is disabled via command line#424
Merged
Conversation
When running with -Dmaven.build.cache.enabled=false, the build would fail with IllegalStateException: "Cache is not initialized. Actual state: DISABLED" because stagePreExistingArtifacts() was being called unconditionally. This commit adds a check for cacheState == INITIALIZED before calling stagePreExistingArtifacts() and restoreStagedArtifacts(), ensuring these cache-dependent operations are only performed when the cache is properly initialized. Fixes the regression reported in PR apache#394 comment.
Adds a test that verifies builds succeed when cache is disabled with -Dmaven.build.cache.enabled=false. This tests the fix for the regression where stagePreExistingArtifacts() was called without checking if the cache was initialized.
Contributor
Author
|
The build is failing due to infrastructure problems:
|
olamy
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When running with
-Dmaven.build.cache.enabled=false, the build fails with:This occurs because
stagePreExistingArtifacts()was being called unconditionally, which internally callscollectCachedArtifactPaths(), which then callscacheConfig.getAttachedOutputs(). ThegetAttachedOutputs()method callscheckInitializedState()which throws when the cache state is DISABLED.Fix
Add a check for
cacheState == INITIALIZEDbefore callingstagePreExistingArtifacts()andrestoreStagedArtifacts(), ensuring these cache-dependent operations are only performed when the cache is properly initialized.Test plan
mvn clean install -Dmaven.build.cache.enabled=falseon a project with the extension - should no longer failFixes the regression reported in #394 (comment)