Skip to content

[MCOMPILER-1006] Fix <proc>only</proc> not triggering annotation processors #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Manas-Dikshit wants to merge 7 commits into
base: master
Choose a base branch
from
+13 −1
Open

[MCOMPILER-1006] Fix <proc>only</proc> not triggering annotation processors #1017

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bb5991c
Refactor execute method for better error handling
Manas-Dikshit Jan 12, 2026
09d6857
Formatting
Manas-Dikshit Jan 26, 2026
cbb8dc6
Refactor comments in AbstractCompilerMojo.java
Manas-Dikshit Jan 27, 2026
64e3df0
Update print statement from 'Hello' to 'Goodbye'
Manas-Dikshit Jan 27, 2026
a6f8f52
Fix annotation processor execution condition
Manas-Dikshit Jan 27, 2026
194dc42
Add method documentation for task creation
Manas-Dikshit Feb 6, 2026
79fb5af
Fix annotation processor condition check
Manas-Dikshit Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1185,8 +1185,17 @@ public void execute() throws MojoException {
supportedVersion = version;
}
}

Options configuration = parseParameters(compiler);
try {
// --- Fix for issue #1006: ensure <proc>only</proc> runs annotation processors
// ---
if ("only".equalsIgnoreCase(compilerConfiguration.getProc())) {
logger.info("Running annotation processors (proc: only)");
compile(compiler, configuration);
return;
}
// -------------------------------------------------------------------------------
Copy link
Contributor

@desruisseaux desruisseaux Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looking for the first time at this pull request seriously (my previous comment was only formatting). What is the purpose of this addition? It does exactly the same thing as before — just invoking compiler(compiler, configuration) — with only a log added.

compile(compiler, configuration);
} catch (RuntimeException e) {
String message = e.getLocalizedMessage();
Expand All @@ -1198,15 +1207,18 @@ public void execute() throws MojoException {
message = message.substring(0, s); // Log only the first line.
}
}

MessageBuilder mb = messageBuilderFactory
.builder()
.strong("COMPILATION ERROR: ")
.a(message);
logger.error(mb.toString(), verbose ? e : null);

if (tipForCommandLineCompilation != null) {
logger.info(tipForCommandLineCompilation);
tipForCommandLineCompilation = null;
}

if (failOnError) {
throw e;
}
Expand All @@ -1215,7 +1227,7 @@ public void execute() throws MojoException {
throw new CompilationFailureException("I/O error while compiling the project.", e);
}
}

Copy link
Contributor

@desruisseaux desruisseaux Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep blank line between methods.

/**
* Creates a new task by taking a snapshot of the current configuration of this <abbr>MOJO</abbr>.
* This method creates the {@linkplain ToolExecutor#outputDirectory output directory} if it does not already exist.
Expand Down