Conversation
slachiewicz
approved these changes
Nov 22, 2025
Bukama
requested changes
Nov 22, 2025
| * | ||
| * @param path | ||
| * @return | ||
| * @return true if the path is relative and false if absolute also returns false if it is relative to the parent |
Contributor
There was a problem hiding this comment.
Inline returns has bracers at the start and end of line (final dot is automatically added at inline return). But this needs Java 16, which we don't use yet for EJB plugin.
But this method has a parameter, so inline return statement is not applicable.
So this Javadoc should needs a useful description, a parameter description and the return description.
Contributor
Author
There was a problem hiding this comment.
yes it does, and that's a separate pre-existing issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.