Open
Conversation
The awaitIdle() method had two problems causing flaky test failures (especially on macOS ARM64 CI runners): 1. Tight busy-loop with no sleep - spins continuously on getAll() which acquires a file lock each iteration, causing contention and wasted CPU 2. 5000ms timeout too short for CI environments under load Fix by adding a 100ms sleep between polls and increasing the timeout to 30 seconds. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestRegistry.awaitIdle()to avoid tight busy-loop spinning on file lock acquisitionProblem
StopStatusTest.stopStatus(and other tests usingawaitIdle) intermittently fail on macOS ARM64 CI runners with:Root cause:
awaitIdle()was a tight busy-loop callinggetAll()on every iteration. EachgetAll()call acquires a file lock on the daemon registry, causing contention. The 5000ms timeout was too short for CI runners under load.Test plan
🤖 Generated with Claude Code