Skip to content

[Issue-3380] Send sourceQualifiedName to forked clients (#3380)#3381

Open
fabriciorby wants to merge 2 commits into
apache:masterfrom
fabriciorby:fix-forked-qualified-name
Open

[Issue-3380] Send sourceQualifiedName to forked clients (#3380)#3381
fabriciorby wants to merge 2 commits into
apache:masterfrom
fabriciorby:fix-forked-qualified-name

Conversation

@fabriciorby

@fabriciorby fabriciorby commented Jun 19, 2026

Copy link
Copy Markdown

The sourceQualifiedName should also be sent to forked clients, so it's added on ForkClient, the EventChannelEncoder and EventDecoder.

It should also be used in the CategorizedReportEntry and implemented properly in WrappedReportEntry.

Check #3380 and #3203

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

The sourceQualifiedName should also be sent to forked clients, so it's added on ForkClient, the EventChannelEncoder and EventDecoder.

It should also be used in the CategorizedReportEntry and implemented properly in WrappedReportEntry.
@fabriciorby

Copy link
Copy Markdown
Author

To run the integration tests I had to change the pom.xml to scope test in surefire-its

    <dependency>
      <groupId>org.apache.maven.surefire</groupId>
      <artifactId>surefire-report-parser</artifactId>
      <version>${project.version}</version>
      <scope>test</scope>
    </dependency>
    <dependency>
      <groupId>org.apache.maven.surefire</groupId>
      <artifactId>surefire-logger-api</artifactId>
      <version>${project.version}</version>
      <scope>test</scope>
    </dependency>

@olamy

olamy commented Jun 20, 2026

Copy link
Copy Markdown
Member

@fabriciorby Thanks!
Could we imagine an IT test to ensure we capture this change?

@olamy olamy added the enhancement New feature or request label Jun 20, 2026
@olamy olamy linked an issue Jun 20, 2026 that may be closed by this pull request
@olamy olamy added this to the 3.6.0-M2 milestone Jun 20, 2026
@fabriciorby

fabriciorby commented Jun 20, 2026

Copy link
Copy Markdown
Author

@olamy I am having too many issues with dependency errors when running the integration tests in my local, so I think the current implementation is enough and I won't go further.

The strategy I got is that the current only possible way of testing this is by relying on the behaviour of this line in StatelessXmlReporter.java so I need to play with phrasedClassName=false in the pom.xml and then basically if original.getSourceQualifiedName() is not null (passed correctly through encode/decode with ForkClient) it should not bring the original.getSourceText(). Which means it should never bring the @DisplayName value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Send sourceQualifiedName to forked clients

2 participants