[Issue-3380] Send sourceQualifiedName to forked clients (#3380)#3381
[Issue-3380] Send sourceQualifiedName to forked clients (#3380)#3381fabriciorby wants to merge 2 commits into
Conversation
The sourceQualifiedName should also be sent to forked clients, so it's added on ForkClient, the EventChannelEncoder and EventDecoder. It should also be used in the CategorizedReportEntry and implemented properly in WrappedReportEntry.
|
To run the integration tests I had to change the |
|
@fabriciorby Thanks! |
|
@olamy I am having too many issues with dependency errors when running the integration tests in my local, so I think the current implementation is enough and I won't go further. The strategy I got is that the current only possible way of testing this is by relying on the behaviour of this line in |
The sourceQualifiedName should also be sent to forked clients, so it's added on ForkClient, the EventChannelEncoder and EventDecoder.
It should also be used in the CategorizedReportEntry and implemented properly in WrappedReportEntry.
Check #3380 and #3203
Following this checklist to help us incorporate your
contribution quickly and easily:
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.