Bug: make all collected args use single quote#11609
Open
cstamas wants to merge 1 commit intoapache:masterfrom
Open
Bug: make all collected args use single quote#11609cstamas wants to merge 1 commit intoapache:masterfrom
cstamas wants to merge 1 commit intoapache:masterfrom
Conversation
Thus, preventing expansion, if applicable. Fixes apache#10421
Contributor
|
@cstamas any update on this? |
Member
Author
|
Someone should review this... |
Contributor
|
It looks fine to me, but I'm far from a bash expert… |
Member
Author
|
@michael-o ping |
michael-o
requested changes
Jan 30, 2026
| # Add remaining arguments with proper quoting | ||
| for arg in "$@"; do | ||
| cmd="$cmd \"$arg\"" | ||
| cmd="$cmd '$arg'" |
Member
There was a problem hiding this comment.
This changes semantics "@" does already the quoting for us. I think this needs an IT.
Member
Author
There was a problem hiding this comment.
So, according to your comment, this change is not needed and the issue it fixes is fluke?
Member
There was a problem hiding this comment.
I didn't say its fluke, but we need to understand what this change causes and an IT with it. I wouldn't easily apply it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thus, preventing expansion, if applicable.
Fixes #10421