Forward port Maven 3.10.0 PluginDependenciesResolver changes#12329
Open
cstamas wants to merge 4 commits into
Open
Forward port Maven 3.10.0 PluginDependenciesResolver changes#12329cstamas wants to merge 4 commits into
cstamas wants to merge 4 commits into
Conversation
Also, restore binary compatibility that was broken in 4-beta-2. This PR aligns PluginDependenciesResolver with changes happened in Maven 3.10.x, and also restores binary incompatibility happened in DefaultPluginDependenciesResolver that used to be injected directly.
Member
Author
|
@gnodet master is broken with this same error |
gnodet
reviewed
Jun 19, 2026
gnodet
left a comment
Contributor
There was a problem hiding this comment.
Nice work aligning the Maven 4.x PluginDependenciesResolver with the 3.10.x changes and restoring the binary compatibility broken in 4-beta-2. The deprecation+delegation pattern is correctly applied, and switching to interface-based injection in BootstrapCoreExtensionManager is the right move.
A couple more observations not tied to specific lines:
- TODO comment: Both
BootstrapCoreExtensionManagerfiles (compat and impl) have a TODO comment above the call site that still referencesresolveCoreExtension. Since the method is nowresolveCoreExtensionAndFlattenand the method is now on the interface, the TODO may be partially addressed and could be refined. @since 3.10.0on new interface methods: The new methods use@since 3.10.0, which correctly references where they originated, but since Maven 4.x and 3.10.x are separate release lines, consumers reading the Maven 4.x javadoc might find this confusing. Flagging for awareness only.- No tests added: No new or modified tests, which is reasonable for an interface evolution / binary compat PR where the behavior is unchanged (new methods delegate to the same
resolveInternallogic).
This review does not replace specialized AI review tools (CodeRabbit, Sourcery) or static analysis (SonarCloud).
Fully automatic review from Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, restore binary compatibility that was broken in 4-beta-2.
This PR aligns PluginDependenciesResolver with changes happened in Maven 3.10.x, and also restores binary incompatibility happened in DefaultPluginDependenciesResolver that used to be injected directly.