nimble/ll: Add Channel Sounding by mkasenberg · Pull Request #1765 · apache/mynewt-nimble

mkasenberg · 2024-04-16T08:42:57Z

No description provided.

sjanc

look good, few nitpicks here and there

sjanc · 2024-05-08T13:58:57Z

+    cssm = connsm->cssm;
+
+    /* Check if a disabled role is used in CS configs */
+    for (int i = 0; i < ARRAY_SIZE(cssm->config); i++) {


nitpick: we typically declare variable at top of the function, also could be unsigned to avoid signed-unsigned comparison

sjanc · 2024-05-08T13:59:36Z

+
+    /* Check if a disabled role is used in CS configs */
+    for (int i = 0; i < ARRAY_SIZE(cssm->config); i++) {
+        struct ble_ll_cs_config *conf = &cssm->config[i];


sjanc · 2024-05-08T14:00:38Z

+    }
+
+    cssm->roles_enabled = cmd->role_enable;
+    cssm->cs_sync_antenna_selection = cmd->cs_sync_antenna_selection;


not sure if we are very consistent with this but maybe sm could be modified only after all validation is done? ie to avoid modifying it and stil returning error status

sjanc · 2024-05-08T14:03:50Z

+int
+ble_ll_cs_rx_fae_req(struct ble_ll_conn_sm *connsm, uint8_t *rspbuf)
+{
+    memcpy(rspbuf, connsm->cssm->local_fae_table, 72);


this is quite a lot, is it guaranteed that there is enough linear space in underlying mbuf?

Good point, there wasn't ;)

sjanc · 2024-05-08T14:08:32Z

+
+    if (!rc) {
+        swap_buf(out_data, ecb.cipher_text, BLE_ENC_BLOCK_SIZE);
+        rc = 0;


rc is already 0 here

sjanc · 2024-05-08T14:10:08Z

+{
+    uint8_t config_id = connsm->cssm->config_req_id;
+    uint8_t action = connsm->cssm->config_req_action;
+    const struct ble_ll_cs_config *conf = &connsm->cssm->config[config_id];


is config_id already validated here?

sjanc · 2024-05-08T14:11:26Z

+        return BLE_ERR_UNK_CONN_ID;
+    }
+
+    conf = &connsm->cssm->config[cmd->config_id];


config_id should be validated before being used for indexing

andrzej-kaczmarek · 2024-06-11T07:40:54Z

+
+pkg.cflags.TEST:
+    - -Irepos/mbedtls/include
+    - -Irepos/include/mbedtls


includes should be added automatically from pkg dep

andrzej-kaczmarek · 2024-06-11T07:55:15Z

+    uint8_t *pv = connsm->cssm->drbg_ctx.pv;
+
+    if (!connsm->flags.encrypted) {
+        return rej_ext_ind_make(BLE_LL_CTRL_CS_SEC_REQ,


ble_ll_ctrl_rej_ext_ind_make + return

andrzej-kaczmarek · 2024-06-11T07:56:24Z

+    struct ble_ll_cs_drbg_ctx *drbg_ctx = &connsm->cssm->drbg_ctx;
+
+    if (!IS_PENDING_CTRL_PROC(connsm, BLE_LL_CTRL_PROC_CS_SEC_START)) {
+        /* Should never happen */


in bluetooth it will happen ;)
just change the comment to "ignore" or smth

andrzej-kaczmarek · 2024-06-11T07:58:11Z

+void
+ble_ll_cs_rx_capabilities_rsp(struct ble_ll_conn_sm *connsm, uint8_t *dptr)
+{
+    ble_ll_cs_update_rem_capabilities(connsm, dptr);


this should verify data in rsp and return error if needed

mkasenberg · 2025-04-03T08:58:24Z

Just rebase

There were changes to HCI between the draft and final version of the Bluetooth 6.0 specification.

Initialize the CS state machine with the connection state machine.

Add lengths and opcodes of Channel Sounding LL CTRL PDUs.

Implement the LE CS Read Local Supported Capabilities command. Enable basic CS capabilities in local controller.

Implements: - LE CS Read Remote Supported Capabilities command, - LE CS Write Cached Remote Supported Capabilities command.

The HCI_LE_CS_Set_Default_Settings command is used by a Host to set default CS settings in the local Controller for the connection.

Implements: - LE CS Read Remote FAE Table command - LE CS Write Cached Remote FAE Table command

Implements: - LE CS Create Config command - LE CS Remove Config command

Implements LE CS Security Enable command.

The spec does not define a mechanism to inform which CS parameter the controller rejects during CS start parameters negotiation, so a few logs on the controller side will definitely be useful.

mkasenberg · 2026-06-26T17:00:36Z

Contains UPF fixes now

mkasenberg force-pushed the cs-setup-phase branch 4 times, most recently from fcafb89 to 6a71e3d Compare April 18, 2024 11:13

sjanc reviewed May 8, 2024

View reviewed changes

mkasenberg force-pushed the cs-setup-phase branch from 6a71e3d to a1d3776 Compare May 9, 2024 13:40

sjanc requested a review from andrzej-kaczmarek May 24, 2024 09:04

sjanc approved these changes May 24, 2024

View reviewed changes

mkasenberg force-pushed the cs-setup-phase branch from a1d3776 to 66e8783 Compare June 10, 2024 11:35

andrzej-kaczmarek requested changes Jun 11, 2024

View reviewed changes

mkasenberg force-pushed the cs-setup-phase branch from 66e8783 to 95655da Compare October 7, 2024 12:03

github-actions Bot added host controller size/XL Extra large PR labels Oct 7, 2024

mkasenberg force-pushed the cs-setup-phase branch from 95655da to e5c19a3 Compare December 28, 2024 14:24

mkasenberg force-pushed the cs-setup-phase branch from e5c19a3 to a206502 Compare January 24, 2025 10:38

mkasenberg force-pushed the cs-setup-phase branch from a206502 to 7fb1152 Compare April 3, 2025 08:57

mkasenberg force-pushed the cs-setup-phase branch from 7fb1152 to 082a16d Compare April 14, 2025 11:40

mkasenberg changed the title ~~nimble/controller: Add Channel Sounding setup phase~~ nimble/ll: Add Channel Sounding Nov 24, 2025

mkasenberg force-pushed the cs-setup-phase branch from 082a16d to 3155c69 Compare November 24, 2025 09:17

github-actions Bot removed the host label Nov 24, 2025

mkasenberg force-pushed the cs-setup-phase branch from 3155c69 to ab2cd80 Compare April 16, 2026 08:44

github-actions Bot added the needs-ci-approval label Apr 16, 2026

mkasenberg force-pushed the cs-setup-phase branch from ab2cd80 to 16396d8 Compare May 5, 2026 11:06

mkasenberg force-pushed the cs-setup-phase branch from 16396d8 to 2125857 Compare May 22, 2026 14:34

mkasenberg added 4 commits June 26, 2026 18:35

nimble/hci: Update Channel Sounding HCI

95d7557

There were changes to HCI between the draft and final version of the Bluetooth 6.0 specification.

nimble/ll: Add Channel Sounding state machine

cd6f331

Initialize the CS state machine with the connection state machine.

nimble/ll: Add Channel Sounding LL CTRL opcodes

03c7f65

Add lengths and opcodes of Channel Sounding LL CTRL PDUs.

nimble/ll: Add Channel Sounding capabilities

e097a91

Implement the LE CS Read Local Supported Capabilities command. Enable basic CS capabilities in local controller.

mkasenberg added 12 commits June 26, 2026 18:35

nimble/ll: Add CS Capabilities Exchange procedure

b317176

Implements: - LE CS Read Remote Supported Capabilities command, - LE CS Write Cached Remote Supported Capabilities command.

nimble/ll: Add LE CS Set Default Settings command

9a38989

The HCI_LE_CS_Set_Default_Settings command is used by a Host to set default CS settings in the local Controller for the connection.

nimble/ll: Add CS Mode-0 FAE Table Request procedure

02df511

Implements: - LE CS Read Remote FAE Table command - LE CS Write Cached Remote FAE Table command

nimble/ll: Add CS Configuration procedure

4e2c625

Implements: - LE CS Create Config command - LE CS Remove Config command

nimble/ll: Add CS Security Start procedure

afd6a81

Implements LE CS Security Enable command.

nimble/ll: Add LE CS Set Channel Classification command

5e695e6

nimble/ll: Add LE CS Set Procedure Parameters command

89a211a

nimble/ll: Add CS Start procedure

b2776b5

nimble/ll: Add initial Channel Sounding scheduling

681245c

nimble/ll: Add unit tests for Channel Sounding CSA #3C

a22ef3b

nimble/ll: Add unit tests for CS parameters validation

7d967ac

nimble/ll: Add BLE_LL_CS_LOG

380017f

The spec does not define a mechanism to inform which CS parameter the controller rejects during CS start parameters negotiation, so a few logs on the controller side will definitely be useful.

mkasenberg force-pushed the cs-setup-phase branch from 2125857 to 380017f Compare June 26, 2026 16:37

Uh oh!

Conversation

mkasenberg commented Apr 16, 2024

Uh oh!

sjanc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkasenberg commented Apr 3, 2025

Uh oh!

mkasenberg commented Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants