nimble/host: Add support for storing client supported features values#2114
nimble/host: Add support for storing client supported features values#2114piotrnarajowski wants to merge 7 commits into
Conversation
piotrnarajowski
force-pushed
the
store_cl_sup_feat
branch
from
9ebf182 to
6c00b45
Compare
piotrnarajowski
changed the title
|
#AutoPTS run mynewt GATT/SR/GAS/BV-04-C |
|
Scheduled PR #2114 (comment), board: nrf52, estimated start time: 15:17:06, test case count: 1, estimated duration: 0:11:01 Test cases to be runGATT/SR/GAS/BV-04-C |
|
AutoPTS Bot results: Successful tests (1)GATT GATT/SR/GAS/BV-04-C PASS |
|
@andrzej-kaczmarek PTAL and enable workflows |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| #endif | ||
|
|
||
| static int | ||
| ble_store_ram_delete_cl_sup_feat(const struct ble_store_key_cl_sup_feat |
Check notice
Code scanning / CodeQL
Unused static function
| } | ||
|
|
||
| static int | ||
| ble_store_ram_read_cl_sup_feat(const struct ble_store_key_cl_sup_feat |
Check notice
Code scanning / CodeQL
Unused static function
| } | ||
|
|
||
| static int | ||
| ble_store_ram_write_cl_sup(const struct ble_store_value_cl_sup_feat |
Check notice
Code scanning / CodeQL
Unused static function
piotrnarajowski
force-pushed
the
store_cl_sup_feat
branch
2 times, most recently
from
ad2f8cd to
3c6f1ab
Compare
|
Fixed coding style issues and updated ble_gatts_peer_cl_sup_feat_update function. Added check for disabling already enabled features for bonded clients |
|
|
||
| #include <inttypes.h> | ||
| #include "nimble/ble.h" | ||
| #include "../../host/src/ble_gatt_priv.h" |
There was a problem hiding this comment.
this needs other solution (eg. move declarations for public headers if now used in API)
we should not include private headers in public headers...
There was a problem hiding this comment.
moved to ble_gatt.h
piotrnarajowski
force-pushed
the
store_cl_sup_feat
branch
from
3c6f1ab to
94c1ea7
Compare
piotrnarajowski
force-pushed
the
store_cl_sup_feat
branch
from
94c1ea7 to
c11f81f
Compare
piotrnarajowski
force-pushed
the
store_cl_sup_feat
branch
from
c11f81f to
a04f248
Compare
|
@MariuszSkamra PTAL |
|
#AutoPTS run mynewt GATT/SR/GAS/BV-04-C |
|
Scheduled PR #2114 (comment), board: nrf52, estimated start time: 15:27:54, test case count: 1, estimated duration: 0:10:57 Test cases to be runGATT/SR/GAS/BV-04-C |
|
AutoPTS Bot results: Successful tests (1)GATT GATT/SR/GAS/BV-04-C PASS |
Add support for BLE_STORE_OBJ_TYPE_PEER_CL_SUP_FEAT. This is used for storing values of Client Supported Features for clients with a trusted relationship.
This adds support for storing client supported features for clients with a trusted relationship. Fixes Host qualification test case GATT/SR/GAS/BV-04-C
Extend storage unit tests to cover new object type PEER_CL_SUP_FEAT
Fix code style in ble_store.h
Moves 'BLE_GATT_CHR_CLI_SUP_FEAT_SZ' from the private header to the public ble_gatt.h header.
Introduce a comprehensive unit test suite to validate the persistance, restoration, and specification compliance of the Client Supported Features characteristic values across peer bonding lifecycles.
Update keystore commands to handle Client Supported Features storage type object.
piotrnarajowski
force-pushed
the
store_cl_sup_feat
branch
from
a04f248 to
8316107
Compare
|
Recent changes introduce Btshell keystore methods update that allows to see if Client Supported Features values has been stored properly for client with trusted relationship |
4 participants
Implements the core mechanism for storing and maintaining Client Supported Features for peers with a trusted relationship. This successfully resolves Host qualification test case GATT/SR/GAS/BV-04-C.
Alongside the core stack changes, storage layer has been extended with a new object type, and a comprehensive unit test suite (ble_gatts_cl_sup_feat_suite) has been added