Skip to content

apps/bttester: Fix BTP event data truncation in GATT Read Long response#2246

Open
piotrnarajowski wants to merge 1 commit into
apache:masterfrom
piotrnarajowski:tester_read_long_cb_fix
Open

apps/bttester: Fix BTP event data truncation in GATT Read Long response#2246
piotrnarajowski wants to merge 1 commit into
apache:masterfrom
piotrnarajowski:tester_read_long_cb_fix

Conversation

@piotrnarajowski

Copy link
Copy Markdown
Contributor

Fixes an issue where large GATT Read Long response (e.g. 512 bytes) was truncated in tester_event causing the GATT/CL/GAR/BV-04-C qualification test case to fail. This was caused by passing buf->om_data and buf->om_len to tester_event. The data exceeding single memory chain buffer was left ignored in next mbuf in the list (buf->om_next).

@piotrnarajowski

Copy link
Copy Markdown
Contributor Author

#AutoPTS run mynewt GATT/CL/GAR

@codecoup-tester

Copy link
Copy Markdown

Scheduled PR #2246 (comment), board: nrf52, estimated start time: 15:22:48, test case count: 36, estimated duration: 0:28:23

Test cases to be runGATT/CL/GAR/BV-01-C
GATT/CL/GAR/BI-01-C
GATT/CL/GAR/BI-02-C
GATT/CL/GAR/BI-03-C
GATT/CL/GAR/BI-04-C
GATT/CL/GAR/BI-05-C
GATT/CL/GAR/BV-03-C
GATT/CL/GAR/BI-06-C
GATT/CL/GAR/BI-07-C
GATT/CL/GAR/BI-09-C
GATT/CL/GAR/BI-10-C
GATT/CL/GAR/BI-11-C
GATT/CL/GAR/BV-04-C
GATT/CL/GAR/BI-12-C
GATT/CL/GAR/BI-13-C
GATT/CL/GAR/BI-14-C
GATT/CL/GAR/BI-15-C
GATT/CL/GAR/BI-16-C
GATT/CL/GAR/BI-17-C
GATT/CL/GAR/BV-05-C
GATT/CL/GAR/BI-18-C
GATT/CL/GAR/BI-19-C
GATT/CL/GAR/BI-20-C
GATT/CL/GAR/BI-21-C
GATT/CL/GAR/BI-22-C
GATT/CL/GAR/BV-06-C
GATT/CL/GAR/BV-07-C
GATT/CL/GAR/BI-35-C
GATT/CL/GAR/BV-08-C
GATT/CL/GAR/BV-10-C
GATT/CL/GAR/BV-11-C
GATT/CL/GAR/BI-36-C
GATT/CL/GAR/BI-38-C
GATT/CL/GAR/BI-40-C
GATT/CL/GAR/BI-42-C
GATT/CL/GAR/BI-44-C

@codecoup-tester

Copy link
Copy Markdown

AutoPTS Bot results:

Failed tests (1)GATT GATT/CL/GAR/BV-11-C INDCSV - ERRATA https://github.com//issues/2002
Successful tests (35)GATT GATT/CL/GAR/BI-01-C PASS
GATT GATT/CL/GAR/BI-02-C PASS
GATT GATT/CL/GAR/BI-03-C PASS
GATT GATT/CL/GAR/BI-04-C PASS
GATT GATT/CL/GAR/BI-05-C PASS
GATT GATT/CL/GAR/BI-06-C PASS
GATT GATT/CL/GAR/BI-07-C PASS
GATT GATT/CL/GAR/BI-09-C PASS
GATT GATT/CL/GAR/BI-10-C PASS
GATT GATT/CL/GAR/BI-11-C PASS
GATT GATT/CL/GAR/BI-12-C PASS
GATT GATT/CL/GAR/BI-13-C PASS
GATT GATT/CL/GAR/BI-14-C PASS
GATT GATT/CL/GAR/BI-15-C PASS
GATT GATT/CL/GAR/BI-16-C PASS
GATT GATT/CL/GAR/BI-17-C PASS
GATT GATT/CL/GAR/BI-18-C PASS
GATT GATT/CL/GAR/BI-19-C PASS
GATT GATT/CL/GAR/BI-20-C PASS
GATT GATT/CL/GAR/BI-21-C PASS
GATT GATT/CL/GAR/BI-22-C PASS
GATT GATT/CL/GAR/BI-35-C PASS
GATT GATT/CL/GAR/BI-36-C PASS
GATT GATT/CL/GAR/BI-38-C PASS
GATT GATT/CL/GAR/BI-40-C PASS
GATT GATT/CL/GAR/BI-42-C PASS
GATT GATT/CL/GAR/BI-44-C PASS
GATT GATT/CL/GAR/BV-01-C PASS
GATT GATT/CL/GAR/BV-03-C PASS
GATT GATT/CL/GAR/BV-04-C PASS
GATT GATT/CL/GAR/BV-05-C PASS
GATT GATT/CL/GAR/BV-06-C PASS
GATT GATT/CL/GAR/BV-07-C PASS
GATT GATT/CL/GAR/BV-08-C PASS
GATT GATT/CL/GAR/BV-10-C PASS

Fixes an issue where large GATT Read Long response (e.g. 512 bytes)
was truncated in tester_event causing the GATT/CL/GAR/BV-04-C
qualification test case to fail. This was caused by passing
buf->om_data and buf->om_len to tester_event. The data exceeding
single memory chain buffer was left ignored in next mbuf in the list
(buf->om_next).
@piotrnarajowski piotrnarajowski force-pushed the tester_read_long_cb_fix branch from 2e99c9f to 4c8a9a9 Compare June 10, 2026 07:54
@piotrnarajowski

Copy link
Copy Markdown
Contributor Author

Minor fix: changed rc = os_mbuf_append(buf, gatt_buf.buf, gatt_buf.len); to os_mbuf_append(buf, gatt_buf.buf, gatt_buf.len);

@piotrnarajowski piotrnarajowski marked this pull request as ready for review June 10, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants