Skip to content

nimble/host: Fix rejected SM SC debug keys #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkasenberg wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −0
Open

nimble/host: Fix rejected SM SC debug keys #2250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions nimble/host/src/ble_sm_sc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,13 +612,15 @@ ble_sm_sc_public_key_rx(uint16_t conn_handle, struct os_mbuf **om,
}

cmd = (struct ble_sm_public_key *)(*om)->om_data;
#if !MYNEWT_VAL(BLE_SM_SC_DEBUG_KEYS)

@sjanc sjanc Jul 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even with debug keys enabled this should allow to have same public keys only if keys is debug

/* Check if the peer public key is same as our generated public key.
* Return fail if the public keys match. */
if (memcmp(cmd, ble_sm_sc_pub_key, 64) == 0) {
res->enc_cb = 1;
res->sm_err = BLE_SM_ERR_AUTHREQ;
return;
}
#endif

ble_hs_lock();
proc = ble_sm_proc_find(conn_handle, BLE_SM_PROC_STATE_PUBLIC_KEY, -1,
Expand Down
Loading