NIFI-15258 Add API for Connectors#70
Merged
exceptionfactory merged 3 commits intoapache:mainfrom Mar 3, 2026
Merged
Conversation
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks @markap14 and all who contributed to the new Connector API! The new interfaces and classes look like a solid foundation for introducing this new capability. I raised a couple minor questions at a few points, but overall it looks ready to be merged soon.
src/main/java/org/apache/nifi/components/connector/components/FlowContextType.java
Show resolved
Hide resolved
src/main/java/org/apache/nifi/components/connector/components/ProcessGroupLifecycle.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/nifi/components/connector/AbstractConnector.java
Show resolved
Hide resolved
src/main/java/org/apache/nifi/components/connector/AbstractConnector.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/nifi/components/connector/AbstractConnector.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/nifi/components/connector/ConnectorPropertyDescriptor.java
Outdated
Show resolved
Hide resolved
exceptionfactory
changed the title
Contributor
Author
|
Thanks for the review @exceptionfactory . Updated to address all review feedback and also rebased against main |
NIFI-15259: Adding web context interface for custom Connector UIs. NIFI-15322: Require all property descriptors within a PropertyGroup / ConfigurationStep are unique (apache#27) * Huge refactoring of Connectors to require that <Step Name, Property Name> tuple is unique. Requiring that is simple, but now that we enforce that, we can greatly simplify much of the code. * Added StepConfiguration to simplify API rather than using Map<String, ConnectorValueReference> in some places * Now that we enforce unique property names per step, introduced StepConfigurationContext to further reduce API complexity NIFI-15326: Adding support for connector configuration step documentation. (apache#28) NIFI-15312: Moved SecretsProvider / SecretsManager to framework instead of api; added description to Secret and updated ParameterProvider to allow more specific fetching of parameters; cleaned up Connector validation logic (apache#29) NIFI-15343: Adding providerId to Secret. (apache#30) NIFI-15258: Enable Custom UI to retrieve connector with flow contexts (apache#33) NIFI-15352: Added getFullyQualifiedName to secret, to encapsulate the combination of group and name (apache#35) NIFI-15352: Added getFullyQualifiedName to SecretReference NIFI-15315 Add support for assets in Connectors (apache#31) - Add ownerIdentifier in Asset and deprecate parameterContextIdentifier - Add ASSET and ASSET_LIST types for Connector properties and update validation - Support multiple asset references NIFI-15361: Removing documentation from ConfigurationStep. (apache#38) NIFI-15369: Allow ConfigurationStep to depend on another (ConfigurationStep,Property) tuple (apache#39) NIFI-15356: Introducing the ConnectorWebMethod. (apache#37) NIFI-15353: Adding documentation writers for connectors. (apache#40) NIFI-15428: If non-existent property value is set, connector should be invalid. (apache#43) NIFI-15427: Added drainFlowFiles(FlowContext) method to Connector (apache#42) NIFI-15440: Implementation of ConnectorActions (apache#47) NIFI-15446: Updated JavaDocs to clarify how invocations of Connector Methods work (apache#45) NIFI-15461: Fixed bug that caused system tests to fail (apache#48) NIFI-15451: Provide ability for Connectors to lookup Bundles available for a given component type (apache#46) NIFI-15485: Include provider name when providing fqn for secrets (apache#52) NIFI-15467: Allow Connectors to specify bundle compatability when upd… (apache#54) NIFI-15536: Change Connector API to use DescribedValue vs AllowableValue (apache#60) NIFI-15514: Bug fix - ensure that when AbstractConnector is started, it includes all components, not just processors and controller services; code cleanup (apache#57) NIFI-15538: When starting/stopping components allow specifying whether or not the action should be recursive; code cleanup and simplification to use a Virtual Thread to execute code sequentially instead of chaining CompletableFutures. (apache#61) NIFI-15480: Added DropFlowFileSummary, ability to drop FlowFiles from a ConnectionFacade / ProcessGroupFacade (apache#62) NIFI-15557: Allow Connectors to enable a Controller Service using overridden property values (apache#63) NIFI-15565: Code cleanup (apache#64) NIFI-15621: Allow Configuration to Validate with ValidationContext (apache#69) Co-authored-by: Mark Payne <markap14@hotmail.com> Co-authored-by: Matt Gilman <matt.c.gilman@gmail.com> Co-authored-by: Bryan Bende <bbende@apache.org> Co-authored-by: Bob Paulin <bob@bobpaulin.com>
Contributor
Author
|
Force pushed again because the rebase dropped my signatures; needed to re-sign the latest 3 commits. |
exceptionfactory
approved these changes
Mar 3, 2026
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the adjustments @markap14! As with any large scale set of changes, I'm sure there be adjustments going forward, but this is a solid foundation for the new Connector capability! +1 merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15258
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranch