NIFI-15670 - Replace List of Map with VersionedNodeState to fix JAXB compatibility#76
Merged
pvillard31 merged 1 commit intoapache:mainfrom Mar 6, 2026
Merged
Conversation
kevdoran
approved these changes
Mar 6, 2026
Contributor
kevdoran
left a comment
There was a problem hiding this comment.
Nice improvement, thanks @pvillard31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15670 - Replace List of Map with VersionedNodeState to fix JAXB compatibility
Without the fix:
The NiFi Registry framework includes a
FlowContentSerializerthat supports multiple data model versions for reading stored flow snapshots. Data model version 1 uses a JAXB-based serializer (JAXBVersionedProcessGroupSerializer), while versions 2 and 3 use Jackson. Although version 1 is a legacy format unlikely to be encountered in practice, all serializers are eagerly instantiated at construction time, meaning JAXB must be able to create a context for the entireVersionedProcessGroupclass hierarchy.This change introduces a
VersionedNodeStatewrapper class containingMap<String, String>and changeslocalNodeStatesfromList<Map<String, String>>toList<VersionedNodeState>, which JAXB can handle since it is a concrete class.Test plan
mvn clean installon nifi-api passesmvn test -pl nifi-registry/nifi-registry-core/nifi-registry-frameworkon NiFi main to confirm the 10 JAXB test failures are resolvedlocalNodeStatesis not yet used in NiFi, so there is no downstream code to updateTracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranch