Skip to content

NIFI-15676 - Add support for custom entries in NAR Manifest#49

Open
pvillard31 wants to merge 2 commits intoapache:mainfrom
pvillard31:NIFI-15676
Open

NIFI-15676 - Add support for custom entries in NAR Manifest#49
pvillard31 wants to merge 2 commits intoapache:mainfrom
pvillard31:NIFI-15676

Conversation

@pvillard31
Copy link
Contributor

NIFI-15676 - Add support for custom entries in NAR Manifest

Configuration

            <plugin>
                <groupId>org.apache.nifi</groupId>
                <artifactId>nifi-nar-maven-plugin</artifactId>
                <extensions>true</extensions>
                <configuration>
                    <enforceDocGeneration>true</enforceDocGeneration>
                    <customManifestEntries>
                        <repo-url>https://github.com/apache/nifi</repo-url>
                    </customManifestEntries>
                </configuration>
            </plugin>

Result

% unzip -p ./nifi-aws-nar/target/nifi-aws-nar-2.9.0-SNAPSHOT.nar META-INF/MANIFEST.MF
Manifest-Version: 1.0
Created-By: Apache NiFi Nar Maven Plugin 2.4.0-SNAPSHOT
Java-Version: 21
Build-Jdk-Spec: 21
Nar-Id: nifi-aws-nar
Nar-Group: org.apache.nifi
Nar-Version: 2.9.0-SNAPSHOT
Nar-Dependency-Group: org.apache.nifi
Nar-Dependency-Id: nifi-aws-service-api-nar
Nar-Dependency-Version: 2.9.0-SNAPSHOT
Build-Tag: HEAD
Build-Timestamp: 2026-02-13T22:38:02Z
Clone-During-Instance-Class-Loading: false
Nar-Custom-repo-url: https://github.com/apache/nifi

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing this addition @pvillard31, the concept makes sense as aligning with JAR manifest handling.

Following that pattern, it seems better to use manifestEntries as the configuration property, and not add any custom prefix. That places more responsibility on plugin configuration for naming, but leaving the naming open follows the pattern of the Maven JAR Plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants