NIFI-15676 - Add support for custom entries in NAR Manifest#49
Open
pvillard31 wants to merge 2 commits intoapache:mainfrom
Open
NIFI-15676 - Add support for custom entries in NAR Manifest#49pvillard31 wants to merge 2 commits intoapache:mainfrom
pvillard31 wants to merge 2 commits intoapache:mainfrom
Conversation
exceptionfactory
requested changes
Mar 6, 2026
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for proposing this addition @pvillard31, the concept makes sense as aligning with JAR manifest handling.
Following that pattern, it seems better to use manifestEntries as the configuration property, and not add any custom prefix. That places more responsibility on plugin configuration for naming, but leaving the naming open follows the pattern of the Maven JAR Plugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NIFI-15676 - Add support for custom entries in NAR Manifest
Configuration
Result