tools/Rust: Add support for x86 platform#2980
Merged
xiaoxiang781216 merged 1 commit intoapache:masterfrom Jan 29, 2025
Merged
Conversation
Summary: - Added support for x86 and x86_64 architectures in the Rust build system - Updated `nuttx_rust_target_triple` function in `cmake/nuttx_add_rust.cmake` to handle x86 and x86_64 target triples - Updated `RUST_TARGET_TRIPLE` macro in `tools/Rust.mk` to include x86 and x86_64 target triples Impact: - Enables Rust crate compilation for x86 and x86_64 platforms - No functional changes for existing architectures (ARM, RISC-V, etc.) - Improves platform compatibility and expands Rust support in NuttX Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
|
[Experimental Bot, please feedback here] Yes, this PR appears to meet the NuttX requirements, although some sections could be more detailed. Specifically:
While the information provided points towards a compliant PR, adding the missing details (especially the testing logs and specific impact details) will ensure it fully adheres to the NuttX guidelines. |
lupyuen
approved these changes
Jan 28, 2025
xiaoxiang781216
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nuttx_rust_target_triplefunction incmake/nuttx_add_rust.cmaketo handle x86 and x86_64 target triplesRUST_TARGET_TRIPLEmacro intools/Rust.mkto include x86 and x86_64 target triplesImpact
Testing
GitHub CI and local build with rust on sim32/sim64
Refer to rust-lang/rust#136181