signals: fix dependency issues when signals are all disabled #3333

wangchdo · 2026-01-15T08:54:39Z

Fix build and runtime issues when signals all disabled.

Summary

This PR fixes dependency issues when signals are all disabled

Impact

Fix dependency issues when signals are all disabled, no impact to any existing functions

Testing

ostest passed on rv-virt:smp64

disable all signals

ostest passed log

NuttShell (NSH)
nsh> 
nsh> uname -a
NuttX 0.0.0 02cfe5cf75-dirty Jan 15 2026 16:37:47 risc-v rv-virt
nsh> 
nsh> ostest

(...)

smp_call_test: Test start
smp_call_test: Call cpu 0, nowait
smp_call_test: Call cpu 0, wait
smp_call_test: Call cpu 1, nowait
smp_call_test: Call cpu 1, wait
smp_call_test: Call cpu 2, nowait
smp_call_test: Call cpu 2, wait
smp_call_test: Call cpu 3, nowait
smp_call_test: Call cpu 3, wait
smp_call_test: Call cpu 4, nowait
smp_call_test: Call cpu 4, wait
smp_call_test: Call cpu 5, nowait
smp_call_test: Call cpu 5, wait
smp_call_test: Call cpu 6, nowait
smp_call_test: Call cpu 6, wait
smp_call_test: Call cpu 7, nowait
smp_call_test: Call cpu 7, wait
smp_call_test: Call multi cpu, nowait
smp_call_test: Call in interrupt, wait
smp_call_test: Call multi cpu, wait
smp_call_test: Test success

Final memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     1fc2d20  1fc2d20
ordblks         1        7
mxordblk  1fb7c78  1f709c0
uordblks     b0a8    16278
fordblks  1fb7c78  1facaa8
user_main: Exiting
ostest_main: Exiting with status 0
nsh>

xiaoxiang781216 · 2026-01-16T01:47:28Z

testing/ostest/Makefile

 CSRCS += suspend.c
 endif
 endif
+endif


move before line 49

xiaoxiang781216 · 2026-01-16T01:48:14Z

testing/ostest/CMakeLists.txt

+        list(APPEND SRCS suspend.c)
+      endif()
    endif()
  endif()


move before line 7 and revert the change from lin3 37-40

xiaoxiang781216 · 2026-01-16T01:50:57Z

examples/ipforward/ipforward.c

  /* Wait for receiver thread to terminate */

+#ifndef CONFIG_DISABLE_ALL_SIGNALS
  pthread_kill(fwd.if_receiver, 9);


need pthread_cancel to make receiver exit? please reference the change in previous pr.

xiaoxiang781216 · 2026-01-16T01:51:13Z

examples/usrsocktest/usrsocktest_wake_with_signal.c

      for (tidx = 0; tidx < nthreads; tidx++)
        {
+#ifndef CONFIG_DISABLE_ALL_SIGNALS
          pthread_kill(tid[tidx], SIGUSR1);


xiaoxiang781216 · 2026-01-16T01:51:28Z

wireless/ieee802154/i8sak/i8sak_events.c

  i8sak->eventlistener_run = false;
+
+#ifndef CONFIG_DISABLE_ALL_SIGNALS
  pthread_kill(i8sak->eventlistener_threadid, 2);


xiaoxiang781216 · 2026-01-16T02:11:12Z

examples/ipforward/ipforward.c

+#ifndef CONFIG_DISABLE_ALL_SIGNALS
  pthread_kill(fwd.if_receiver, 9);
+#else
+  pthread_cancel(fwd.if_receiver);


need change like: https://github.com/apache/nuttx-apps/pull/3265/changes#diff-443998bbc02522d63d612a3f5c97bcba7a159c8f3f3353a65a9435444679d490R536-R545

Do you mean update it like this? (use #ifdef CONFIG_ENABLE_ALL_SIGNALS):

#ifdef CONFIG_ENABLE_ALL_SIGNALS pthread_kill(fwd.if_receiver, 9); #else pthread_cancel(fwd.if_receiver); #endif

something like this:

#ifndef CONFIG_ENABLE_ALL_SIGNALS pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, NULL); pthread_setcanceltype(PTHREAD_CANCEL_DEFERRED, NULL); #endif while (1) { #ifndef CONFIG_ENABLE_ALL_SIGNALS pthread_testcancel(); #endif

xiaoxiang781216 · 2026-01-16T04:41:21Z

wireless/ieee802154/i8sak/i8sak_events.c


  i8sak->eventlistener_run = false;
+
+#ifdef CONFIG_ENABLE_ALL_SIGNALS


Suggested change

#ifdef CONFIG_ENABLE_ALL_SIGNALS

#ifdef CONFIG_DISABLE_ALL_SIGNALS

pthread_cancel(i8sak->eventlistener_threadid);

#else

pthread_kill(i8sak->eventlistener_threadid, 2);

#endif

xiaoxiang781216 · 2026-01-16T04:41:53Z

wireless/ieee802154/i8sak/i8sak_events.c

  FAR struct ieee802154_primitive_s *primitive = NULL;
  int ret = OK;

+#ifndef CONFIG_ENABLE_ALL_SIGNALS


Suggested change

#ifndef CONFIG_ENABLE_ALL_SIGNALS

#ifdef CONFIG_DISABLE_ALL_SIGNALS

xiaoxiang781216 · 2026-01-16T04:43:41Z

testing/ostest/mqueue.c


  /* Wake up the receiver thread with a signal */

+#ifdef CONFIG_ENABLE_ALL_SIGNALS


Suggested change

#ifdef CONFIG_ENABLE_ALL_SIGNALS

#ifndef CONFIG_DISABLE_ALL_SIGNALS

xiaoxiang781216 · 2026-01-16T04:44:17Z

wireless/ieee802154/i8sak/i8sak_events.c


  while (i8sak->eventlistener_run)
    {
+#ifndef CONFIG_ENABLE_ALL_SIGNALS


Suggested change

#ifndef CONFIG_ENABLE_ALL_SIGNALS

#ifdef CONFIG_DISABLE_ALL_SIGNALS

xiaoxiang781216 · 2026-01-16T04:45:57Z

testing/ostest/mqueue.c


+#ifdef CONFIG_ENABLE_ALL_SIGNALS
  printf("mqueue_test: Killing receiver\n");
  pthread_kill(receiver, SIGUSR1);


should we skip the test from build

Agree, I removed the test from build.

xiaoxiang781216 · 2026-01-16T04:47:08Z

system/sensortest/sensortest.c

      return -EINVAL;
    }

+#ifdef CONFIG_ENABLE_ALL_SIGNALS


should skip the test in this case or modify the code to make it work really

I chose to remove the test from build.

xiaoxiang781216 · 2026-01-16T04:47:46Z

examples/usrsocktest/usrsocktest_wake_with_signal.c


      for (tidx = 0; tidx < nthreads; tidx++)
        {
+#ifdef CONFIG_ENABLE_ALL_SIGNALS


Suggested change

#ifdef CONFIG_ENABLE_ALL_SIGNALS

#ifdef CONFIG_DISABLE_ALL_SIGNALS

xiaoxiang781216 · 2026-01-16T04:47:53Z

examples/usrsocktest/usrsocktest_wake_with_signal.c

  TEST_ASSERT_TRUE(test_abort);
  TEST_ASSERT_TRUE(test_hang || !test_hang);

+#ifndef CONFIG_ENABLE_ALL_SIGNALS


Fix build and runtime issues when signals all disabled. Signed-off-by: Chengdong Wang <wangchengdong@lixiang.com>

github-actions bot added Area: Testing Area: NSH Area: Examples Area: Wireless Size: S labels Jan 15, 2026

xiaoxiang781216 previously approved these changes Jan 15, 2026

View reviewed changes

wangchdo dismissed xiaoxiang781216’s stale review via 0ca6612 January 15, 2026 09:04

wangchdo force-pushed the enable_disable_all_signals branch 5 times, most recently from e1cf0b0 to 0625200 Compare January 15, 2026 12:11

github-actions bot added the Area: System label Jan 15, 2026

wangchdo force-pushed the enable_disable_all_signals branch from 0625200 to cf6a657 Compare January 16, 2026 00:58

wangchdo mentioned this pull request Jan 16, 2026

sched/signals: add support to partially or fully disable signals apache/nuttx#17644

Open

xiaoxiang781216 reviewed Jan 16, 2026

View reviewed changes

wangchdo force-pushed the enable_disable_all_signals branch from cf6a657 to e3804fa Compare January 16, 2026 02:02

xiaoxiang781216 reviewed Jan 16, 2026

View reviewed changes

wangchdo force-pushed the enable_disable_all_signals branch 2 times, most recently from af94348 to 0cc5a9a Compare January 16, 2026 04:04

github-actions bot added the Size: M label Jan 16, 2026

xiaoxiang781216 reviewed Jan 16, 2026

View reviewed changes

wangchdo force-pushed the enable_disable_all_signals branch 5 times, most recently from 66096e1 to 62f6066 Compare January 16, 2026 09:21

github-actions bot added the Area: CAN label Jan 16, 2026

signals: fix build and runtime issues when signals all isabled

8610764

Fix build and runtime issues when signals all disabled. Signed-off-by: Chengdong Wang <wangchengdong@lixiang.com>

wangchdo force-pushed the enable_disable_all_signals branch from 62f6066 to 8610764 Compare January 16, 2026 09:52


		i8sak->eventlistener_run = false;

		#ifdef CONFIG_ENABLE_ALL_SIGNALS

	#ifndef CONFIG_ENABLE_ALL_SIGNALS
	#ifdef CONFIG_DISABLE_ALL_SIGNALS


		/* Wake up the receiver thread with a signal */

		#ifdef CONFIG_ENABLE_ALL_SIGNALS

	#ifdef CONFIG_ENABLE_ALL_SIGNALS
	#ifndef CONFIG_DISABLE_ALL_SIGNALS

signals: fix dependency issues when signals are all disabled #3333

Are you sure you want to change the base?

signals: fix dependency issues when signals are all disabled #3333

Conversation

wangchdo commented Jan 15, 2026

Summary

Impact

Testing

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants