nshlib/nsh_fscmds: Display modification time in ls -l output#3571
Open
Zepp-Hanzj wants to merge 1 commit into
Open
nshlib/nsh_fscmds: Display modification time in ls -l output#3571Zepp-Hanzj wants to merge 1 commit into
Zepp-Hanzj wants to merge 1 commit into
Conversation
|
|
||
| /* Display modification time */ | ||
|
|
||
| if (buf.st_mtime != 0) |
Contributor
There was a problem hiding this comment.
need move just before file name
Contributor
Author
There was a problem hiding this comment.
Done. Moved the timestamp display to just before the filename, after the size output.
| } | ||
|
|
||
| #ifdef CONFIG_SCHED_USER_IDENTITY | ||
| if ((lsflags & LSFLAGS_UID_GID) != 0) |
Contributor
There was a problem hiding this comment.
let's remove LSFLAGS_UID_GID, but check LSFLAGS_LONG
Contributor
Author
There was a problem hiding this comment.
Done. Now checking only LSFLAGS_LONG: if ((lsflags & LSFLAGS_LONG) != 0 && buf.st_mtime != 0)
acassis
previously approved these changes
Jun 29, 2026
Fixes #17063 Add modification time display to ls -l long format output. The timestamp is shown as 'YYYY-MM-DD HH:MM' between the permission string and the file size, following the ISO long-iso format. Files with st_mtime == 0 (e.g., procfs, tmpfs pseudo-entries) skip the timestamp display to avoid showing a meaningless epoch time. Signed-off-by: hanzhijian <hanzhijian@zepp.com>
Zepp-Hanzj
force-pushed
the
fix/ls-long-timestamp
branch
from
e9faf9f to
b4d34c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add modification time display to
ls -llong format output.Fixes #17063
Details
The
ls -lcommand now shows the modification time (st_mtime) inYYYY-MM-DD HH:MMformat (ISO long-iso style) between the permissionstring and the file size.
Files with
st_mtime == 0(e.g., procfs, tmpfs pseudo-entries) skipthe timestamp display to avoid showing a meaningless epoch time.
Changes
nshlib/nsh_fscmds.c: Add#include <time.h>and timestamp displaylogic in
ls_handler()after the permission details output.Verification
Built and tested on
sim:nshconfiguration.ls -l /:
ls -l /data:
ls -l /proc (procfs, st_mtime == 0, timestamp correctly skipped):
ls -l /dev (pseudo-devices, st_mtime set to boot time):
rtc0hasst_mtime == 0so the timestamp is correctly omitted.Signed-off-by: hanzhijian hanzhijian@zepp.com