Skip to content

applications/audioutils/morsey: Update Morsey version#3654

Open
linguini1 wants to merge 1 commit into
apache:masterfrom
linguini1:morsey-version
Open

applications/audioutils/morsey: Update Morsey version#3654
linguini1 wants to merge 1 commit into
apache:masterfrom
linguini1:morsey-version

Conversation

@linguini1

Copy link
Copy Markdown
Contributor

Summary

Use newer version without compile time warnings that prevent CI from building.

Impact

Will fix the CI error in apache/nuttx#19493

Testing

Run local build, observe warning is gone:

Before:

morsey/morsey.c: In function 'morsey_lookup':
Error: morsey/morsey.c:137:28: error: array subscript has type 'char' [-Werror=char-subscripts]
  137 |       return &MORSEY_LOOKUP[c];
      |                            ^
cc1: all warnings being treated as errors
make[2]: *** [/github/workspace/sources/apps/Application.mk:265: morsey/morsey.c.github.workspace.sources.apps.audioutils.morsey.o] Error 1
make[2]: Target 'all' not remade because of errors.
make[1]: *** [Makefile:54: /github/workspace/sources/apps/audioutils/morsey_all] Error 2
make[1]: Target 'all' not remade because of errors.
make: *** [tools/LibTargets.mk:248: /github/workspace/sources/apps/libapps.a] Error 2
make: Target 'all' not remade because of errors.

After:

$ ./tools/configure.sh sim:txmorse && make -j
  Copy files
  Select CONFIG_HOST_LINUX=y
  Refreshing...
CP: arch/dummy/Kconfig to /home/linguini/coding/nuttx-space/nuttx/arch/dummy/dummy_kconfig
CP: boards/dummy/Kconfig to /home/linguini/coding/nuttx-space/nuttx/boards/dummy/dummy_kconfig
LN: platform/board to /home/linguini/coding/nuttx-space/apps/platform/dummy
LN: include/arch to arch/sim/include
LN: include/arch/board to /home/linguini/coding/nuttx-space/nuttx/boards/sim/sim/sim/include
LN: drivers/platform to /home/linguini/coding/nuttx-space/nuttx/drivers/dummy
LN: include/arch/chip to /home/linguini/coding/nuttx-space/nuttx/arch/sim/include/sim
LN: arch/sim/src/chip to /home/linguini/coding/nuttx-space/nuttx/arch/sim/src/sim
LN: arch/sim/src/board to /home/linguini/coding/nuttx-space/nuttx/boards/sim/sim/sim/src
mkkconfig in /home/linguini/coding/nuttx-space/apps/audioutils
mkkconfig in /home/linguini/coding/nuttx-space/apps/benchmarks
mkkconfig in /home/linguini/coding/nuttx-space/apps/boot
mkkconfig in /home/linguini/coding/nuttx-space/apps/canutils
mkkconfig in /home/linguini/coding/nuttx-space/apps/crypto
mkkconfig in /home/linguini/coding/nuttx-space/apps/database
mkkconfig in /home/linguini/coding/nuttx-space/apps/examples/elf/tests
mkkconfig in /home/linguini/coding/nuttx-space/apps/examples/elf
mkkconfig in /home/linguini/coding/nuttx-space/apps/examples/mcuboot
mkkconfig in /home/linguini/coding/nuttx-space/apps/examples/module
mkkconfig in /home/linguini/coding/nuttx-space/apps/examples/rust
mkkconfig in /home/linguini/coding/nuttx-space/apps/examples/sotest
mkkconfig in /home/linguini/coding/nuttx-space/apps/examples
mkkconfig in /home/linguini/coding/nuttx-space/apps/fsutils
mkkconfig in /home/linguini/coding/nuttx-space/apps/games
mkkconfig in /home/linguini/coding/nuttx-space/apps/graphics
mkkconfig in /home/linguini/coding/nuttx-space/apps/industry/modbus
mkkconfig in /home/linguini/coding/nuttx-space/apps/industry
mkkconfig in /home/linguini/coding/nuttx-space/apps/inertial
mkkconfig in /home/linguini/coding/nuttx-space/apps/interpreters/luamodules
mkkconfig in /home/linguini/coding/nuttx-space/apps/interpreters
mkkconfig in /home/linguini/coding/nuttx-space/apps/logging
mkkconfig in /home/linguini/coding/nuttx-space/apps/lte
mkkconfig in /home/linguini/coding/nuttx-space/apps/math
mkkconfig in /home/linguini/coding/nuttx-space/apps/mlearning
mkkconfig in /home/linguini/coding/nuttx-space/apps/netutils
mkkconfig in /home/linguini/coding/nuttx-space/apps/pygmy-telem
mkkconfig in /home/linguini/coding/nuttx-space/apps/rocket-altimeter
mkkconfig in /home/linguini/coding/nuttx-space/apps/sdr
mkkconfig in /home/linguini/coding/nuttx-space/apps/system
mkkconfig in /home/linguini/coding/nuttx-space/apps/tee
mkkconfig in /home/linguini/coding/nuttx-space/apps/testing/arch
mkkconfig in /home/linguini/coding/nuttx-space/apps/testing/cxx
mkkconfig in /home/linguini/coding/nuttx-space/apps/testing/drivers
mkkconfig in /home/linguini/coding/nuttx-space/apps/testing/fs
mkkconfig in /home/linguini/coding/nuttx-space/apps/testing/libc
mkkconfig in /home/linguini/coding/nuttx-space/apps/testing/mm
mkkconfig in /home/linguini/coding/nuttx-space/apps/testing/sched
mkkconfig in /home/linguini/coding/nuttx-space/apps/testing
mkkconfig in /home/linguini/coding/nuttx-space/apps/videoutils
mkkconfig in /home/linguini/coding/nuttx-space/apps/wireless/bluetooth
mkkconfig in /home/linguini/coding/nuttx-space/apps/wireless/ieee802154
mkkconfig in /home/linguini/coding/nuttx-space/apps/wireless
mkkconfig in /home/linguini/coding/nuttx-space/apps
#
# configuration written to .config
#
Create version.h
Cloning Morsey repo...
Cloning into 'morsey'...
LN: platform/board to /home/linguini/coding/nuttx-space/apps/platform/dummy
remote: Enumerating objects: 10, done.
remote: Counting objects: 100% (10/10), done.
remote: Compressing objects: 100% (10/10), done.
remote: Total 10 (delta 0), reused 5 (delta 0), pack-reused 0 (from 0)
Receiving objects: 100% (10/10), 11.35 KiB | 332.00 KiB/s, done.
Note: switching to 'a80569e95d0e3aa3bfae17cfe6536c7cae723d50'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

Checking Morsey hashes...
Register: dumpstack
Register: ostest
Register: txmorse
Register: nsh
Register: sh
Register: gpio
Register: dd
Register: hello
Register: gcov
CP:  /home/linguini/coding/nuttx-space/nuttx/include/nuttx/config.h
CP:  /home/linguini/coding/nuttx-space/nuttx/include/nuttx/fs/hostfs.h
LD:  nuttx
Pac SIM with dynamic libs..
'/usr/lib/libm.so.6' -> 'sim-pac/libs/libm.so.6'
'/usr/lib/libz.so.1' -> 'sim-pac/libs/libz.so.1'
'/usr/lib/libc.so.6' -> 'sim-pac/libs/libc.so.6'
'/usr/lib64/ld-linux-x86-64.so.2' -> 'sim-pac/libs/ld-linux-x86-64.so.2'
'/lib64/ld-linux-x86-64.so.2' -> 'sim-pac/ld-linux-x86-64.so.2'
SIM elf with dynamic libs archive in nuttx.tgz

Use newer version without compile time warnings that prevent CI from
building.

Signed-off-by: Matteo Golin <matteo.golin@gmail.com>
@linguini1

Copy link
Copy Markdown
Contributor Author

@acassis any idea why sim:login fails?

@acassis

acassis commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@acassis any idea why sim:login fails?

I think it was because recent modifications that @Abhishekmishra2808 submitted.

Please try to rebase to confirm everything is fine.

@Abhishekmishra2808 could you please help?

@Abhishekmishra2808

Copy link
Copy Markdown
Contributor

Hey @linguini1 and @acassis, apologies for the inconvenience.

This PR needs to be merged: #3557, but the #3557 CI is failing due to a circular configuration dependency. I have raised a fix at apache/nuttx#19498.

After apache/nuttx#19498 is merged, we can hopefully have green CI for #3557. Then, after #3557 is merged, the sim-02 build would pass for this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants