Fix/dropbear cryptodev defconfigs#19492
Merged
jerpelea merged 2 commits intoJul 21, 2026
Merged
Conversation
github-actions
Bot
added
Size: XS
|
Contributor
|
@FelipeMdeO boards/sim/sim/sim/configs/dropbear/defconfig is not normalized |
apache/nuttx-apps#3636 depends on it; without it NETUTILS_DROPBEAR silently disables on reconfigure. Signed-off-by: Felipe Moura <moura.fmo@gmail.com>
apache/nuttx-apps#3636 depends on it; without it NETUTILS_DROPBEAR silently disables on reconfigure. Signed-off-by: Felipe Moura <moura.fmo@gmail.com>
FelipeMdeO
force-pushed
the
fix/dropbear-cryptodev-defconfigs
branch
from
July 21, 2026 00:38
08f5e1d to
5bff9ff
Compare
xiaoxiang781216
approved these changes
Jul 21, 2026
Contributor
Author
Done |
xiaoxiang781216
approved these changes
Jul 21, 2026
jerpelea
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apache/nuttx-apps#3636 replaces Dropbear's
select CRYPTOwithdepends on CRYPTO_CRYPTODEV+depends on CRYPTO_CRYPTODEV_SOFTWARE_CRYPTO.Without those symbols in the board defconfig,
NETUTILS_DROPBEARsilentlydisables on reconfigure. This fixes apache/nuttx-apps#3636's broken CI: its
"Normalize sim/dropbear" check fails because
make savedefconfigdropsCONFIG_NETUTILS_DROPBEARentirely once the dependency isn't met.Adds
CONFIG_CRYPTO_CRYPTODEV,CONFIG_CRYPTO_CRYPTODEV_SOFTWARE_CRYPTO,and
CONFIG_CRYPTO_SW_AESto thesim:dropbearandstm32f746g-disco:dropbeardefconfigs.Impact
Two defconfigs, a few lines each. No other changes.
Testing
Both configs build clean and
make savedefconfiground-trips with no diffagainst the committed defconfig (
sim:dropbearandstm32f746g-disco:dropbear).