drivers/mmcsd: fix eMMC bus width switch sequencing#19502
Merged
xiaoxiang781216 merged 1 commit intoJul 23, 2026
Conversation
xiaoxiang781216
approved these changes
Jul 22, 2026
Contributor
|
@13022591351 please rebase your patch to the last master which fix the ci break. |
Two sequencing problems in the MMC wide bus path break eMMC 4-bit operation on hosts that program the bus width in the SDIO widebus / clock callbacks (e.g. STM32H7): 1. The SWITCH command (CMD6) is issued before the host has switched to wide bus operation. When the card completes the switch while the host is still in 1-bit mode the switch never takes effect and every following data transfer times out. Switch the host to wide bus operation before issuing CMD6. 2. The transfer clock is selected only at the end of mmcsd_widebus(), so the whole switch sequence runs at ID-mode clock and, on the affected hosts, the final clock update does not take effect either, leaving the bus at ~400 kHz. Select the MMC transfer clock before calling mmcsd_widebus(), and pick CLOCK_MMC_TRANSFER_4BIT when wide bus operation is active (mirroring the SD card path) so a later clock selection cannot revert the host to 1-bit. No behavior change for SD cards, and no change on hosts whose widebus callback only records the requested state. Tested on a custom STM32H743 board with eMMC: sd_bench sequential write ~4.1 MB/s, sequential read ~6.3 MB/s (previously all data transfers timed out). Signed-off-by: DuoYuWang <thirteenking.wang@gmail.com>
13022591351
force-pushed
the
mmcsd-emmc-switch-sequencing
branch
from
July 22, 2026 23:45
dac4891 to
7dc243b
Compare
xiaoxiang781216
approved these changes
Jul 23, 2026
jerpelea
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MMC wide bus switch sequence breaks eMMC 4-bit operation on hosts
that program the bus width in the SDIO widebus/clock callbacks (e.g.
STM32H7): CMD6 is issued before the host switched to wide bus (the
switch silently fails and all following transfers time out), and the
transfer clock is only selected after the switch sequence (it never
takes effect, leaving the bus at ID-mode ~400 kHz).
Switch the host to wide bus before CMD6, select the MMC transfer clock
before calling mmcsd_widebus(), and use CLOCK_MMC_TRANSFER_4BIT when
wide bus operation is active (mirroring the SD path).
Impact
MMC/eMMC only. SD cards are unaffected; hosts whose widebus callback
only records state are unaffected.
Testing
Custom STM32H743 board with eMMC: sd_bench sequential write ~4.1 MB/s,
read ~6.3 MB/s (previously all data transfers timed out).