Fix models elements min length#194
Open
MonkeyCanCode wants to merge 1 commit into
Open
Conversation
xiedeyantu
reviewed
Jul 14, 2026
| description: Optional[str] = None | ||
| ai_context: Optional[OSIAIContext] = None | ||
| datasets: list[OSIDataset] | ||
| datasets: list[OSIDataset] = Field(..., min_length=1) |
Member
There was a problem hiding this comment.
Can we leave datasets empty?
Contributor
Author
There was a problem hiding this comment.
From the spec, it should be min 1. Any reason to keep it empty?
Member
There was a problem hiding this comment.
Will we reserve some empty datasets? I'm not entirely sure, but if you're sure about this, I think it's fine.
Contributor
Author
There was a problem hiding this comment.
Per the JSON schema (https://github.com/apache/ossie/blob/main/core-spec/osi-schema.json#L302), datasets has "minItems": 1. A semantic model with no datasets is meaningless. Also, as models are frozen, so we can't do incremental build case as well. I think keep the min of 1 here is more semantic correct as the spec itself doesn't allow empty.
jbonofre
self-requested a review
July 14, 2026 18:43
xiedeyantu
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at https://github.com/apache/ossie/blob/main/core-spec/osi-schema.json,
from_columns,to_columns, anddatasetsshould not allow empty list (which is the current behavior) as their min is1based on the spec: