HDDS-15378. Add component labels for PRs based on changed files#10851
Open
chihsuan wants to merge 2 commits into
Open
HDDS-15378. Add component labels for PRs based on changed files#10851chihsuan wants to merge 2 commits into
chihsuan wants to merge 2 commits into
Conversation
chihsuan
marked this pull request as ready for review
July 23, 2026 15:49
adoroszlai
reviewed
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Problem. Component labels are not applied consistently, so reviewers cannot reliably filter PRs by area such as SCM, OM, datanode, Recon, or S3.
HDDS-10450 previously added
actions/labelerusingpull_request_target. HDDS-13777 removed it because the labeler-only green checkmark could be mistaken for completed CI.Solution. Extend the existing scheduled labeling workflow without using
pull_requestorpull_request_target, so labeling does not produce a check on individual PRs..github/labeler.yml, mapping changed paths to 13 existing labels:scm,om,datanode,recon,s3,client,ofs,EC,command-line,tools,documentation,UI, andCI. No new labels are created.component-labelerjob that lists all open PRs and passes their numbers to the SHA-pinnedactions/labeler.sync-labels: true. Labels in.github/labeler.ymlare automation-owned and are added or removed according to the current changed files. Unlisted labels, such aszduandneeds review, are not modified..githubso the configuration is read locally rather than fetched through the API for every PR.zdubranch-labeling logic.base-branchmatching does not work whenactions/labeleris invoked throughpr-numberfrom a scheduled workflow because the event payload contains no PR branch information.GITHUB_TOKENlimit of 1,000 requests per hour. The tradeoff is that labels may take up to 30 minutes to appear.Expected first-run impact. Simulating the rules against the current 125 open PRs would add approximately 146 labels and remove approximately five existing managed labels that do not match the changed paths.
One open question is the meaning of
s3: some PRs use it as a topic label without modifying S3 Gateway paths. For example, #10006 is an S3 design doc, labeleds3by topic, but it only changeshadoop-hdds/docs, so the sync would replaces3withdocumentationthere. A path-based rule cannot reproduce that usage. Ifs3should remain manually managed, its rule can be removed from.github/labeler.yml.Release/backport, patch-size, review-state, and Jira labels are left for separate changes.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15378
How was this patch tested?
rat.shpassed;actionlintandzizmorreported no new findings.https://github.com/chihsuan/ozone/actions/runs/30018395798
zduPR, and multiple PR numbers in one invocation.zduandneeds reviewremain unchanged; andGenerated-by: Claude Code (Opus 4.8)