Skip to content

HDDS-15966. Fix flaky TestScmHAFinalization#testSnapshotFinalization #10863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
errose28 wants to merge 2 commits into
base: HDDS-14496-zdu
Choose a base branch
from
+2 −1
Open

HDDS-15966. Fix flaky TestScmHAFinalization#testSnapshotFinalization #10863

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f3b727
Remove safemode requirement from test finalize check
errose28 Jul 24, 2026
b75bc6a
Update comment
errose28 Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...e/integration-test/src/test/java/org/apache/hadoop/hdds/upgrade/HddsUpgradeTestUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ private static boolean isScmFinalized(StorageContainerManager scm, boolean waitF
"Requiring DB key to flush? {}",
scm.getSCMNodeId(), scm.checkLeader(), exitedSafemode, isFinalized, dbKeyFlushed, waitForDBKeyFlush);

return exitedSafemode && isFinalized && (!waitForDBKeyFlush || dbKeyFlushed);
// Safemode exit status is included for logging purposes, but SCMs can still finalize while in safemode.
return isFinalized && (!waitForDBKeyFlush || dbKeyFlushed);
}
}
Loading