Skip to content

Use standard commit message for scala-steward#149

Open
mdedetrich wants to merge 1 commit intoapache:1.0.xfrom
mdedetrich:use-standard-commit-message
Open

Use standard commit message for scala-steward#149
mdedetrich wants to merge 1 commit intoapache:1.0.xfrom
mdedetrich:use-standard-commit-message

Conversation

@mdedetrich
Copy link
Copy Markdown
Contributor

(cherry picked from commit 808ce67)

Copy link
Copy Markdown
Member

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't use scala steward on branches - backport is not needed

@mdedetrich
Copy link
Copy Markdown
Contributor Author

we don't use scala steward on branches - backport is not needed

I know, but doing it now so we don't forget just incase we decide to change our minds later

@pjfanning
Copy link
Copy Markdown
Member

if we do start running scala steward on branches, we will need to very carefully set up its conf - so no point backporting micro changes

@mdedetrich
Copy link
Copy Markdown
Contributor Author

mdedetrich commented Mar 10, 2024

if we do start running scala steward on branches, we will need to very carefully set up its conf - so no point backporting micro changes

Im just making sure that the relevant settings are in sync with the branches which goes hand in hand with making sure the conf is carefully setup.

Regardless of whether or not we setup a conf for the other branches, there is no reason not to have this change specifically (I am not backporting version pins for example)

If this PR was made before 1.0.x branch was setup we wouldn't even be having a discussion on this as it would already be done.

@He-Pin
Copy link
Copy Markdown
Member

He-Pin commented Mar 11, 2024

I think it is fine, it will help us to diff when do later backporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants