Open
Conversation
Roiocam
force-pushed
the
optimized-event-tags
branch
from
ae45757 to
df40ca0
Compare
pjfanning
reviewed
Nov 26, 2025
core/src/main/mima-filters/2.0.x.backwards.excludes/event-tags-insert-optimized.excludes
Show resolved
Hide resolved
Merged
pjfanning
force-pushed
the
optimized-event-tags
branch
from
0503de2 to
3378e14
Compare
Member
|
@Roiocam I took your fixes for the typos and applied then separately. I rebased your PR if that is ok. I have a question about the migration sql files. They seem useful but would I be right in saying that users will need to run them themselves or are they automatically applied? The reason I ask is that I plan to push on the 1.2.0 release and there are db schema changes in it and I'm wondering if I should add migration scripts to 1.2.0. So far, I just document in the release notes that there are changes and that users can apply them for themselves. #390 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.