Catalog Migrator: Add missing BUNDLE-NOTICE and BUNDLE-LICENSE entries#196
Open
ajantha-bhat wants to merge 1 commit intoapache:mainfrom
Open
Catalog Migrator: Add missing BUNDLE-NOTICE and BUNDLE-LICENSE entries#196ajantha-bhat wants to merge 1 commit intoapache:mainfrom
ajantha-bhat wants to merge 1 commit intoapache:mainfrom
Conversation
Add NOTICE propagation for 5 non-ASF, Apache 2.0 licensed dependencies that have substantive NOTICE files in their source repos: - Snappy Java (xerial): Google Snappy and Hadoop PureJavaCrc32C attributions - HawtJNI (Fusesource): FuseSource Corp, Progress Software, IBM attributions - BoneCP (Jolbox): Copyright 2010 Wallace Wadge - Eigenbase Properties: Copyright Julian Hyde and DynamoBI Corporation - Groovy (Codehaus 2.4.4, pre-ASF): Copyright 2003-2015, third-party software list Add iq80 LevelDB as a separate BUNDLE-LICENSE entry since its classes (org/iq80/leveldb/*) are bundled in the uber jar as a distinct project from LevelDBJNI (Fusesource).
Member
Author
|
This PR is for next release. |
dimas-b
reviewed
Mar 23, 2026
Comment on lines
+170
to
+177
| This artifact bundles Snappy Java with the following in its NOTICE: | ||
| | This product includes software developed by Google Snappy. | ||
| | (http://code.google.com/p/snappy) | ||
| | | ||
| | This product includes software developed by Apache | ||
| | PureJavaCrc32C from apache-hadoop-common. | ||
| | (http://hadoop.apache.org) | ||
|
|
There was a problem hiding this comment.
Cf. https://github.com/xerial/snappy-java/blob/main/NOTICE
(which version do we bundle?)
Why do we not mention the "google" and "PureJavaCrc32C" fragments exactly as in the upstream NOTICE?
Why do not mention "libstdc++"?
Why do not mention Hadoop? The LICENSE file mentions that it is bundled 🤔
Should we also include the "Contributors" section from upstream? I tend to think we should since it's part of Snappy-java's original NOTICE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BUNDLE-NOTICE entries added:
BUNDLE-LICENSE entry added:
org/iq80/leveldb/*(source)Test plan
./gradlew ratpasses./gradlew :iceberg-catalog-migrator-cli:shadowJarbuilds successfullyMETA-INF/NOTICEin the uber jar contains all new entries